This is an archive of the discontinued LLVM Phabricator instance.

Differential D133332

[MemorySSA][NFC] Simplify if condition
ClosedPublic

Authored by StephenFan on Sep 5 2022, 6:53 PM.

Details

Reviewers
nikic
asbirlea
fhahn
Commits
rG2e7aed1947d2: [MemorySSA][NFC] Simplify if condition

Diff Detail

Event Timeline

StephenFan created this revision.Sep 5 2022, 6:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 5 2022, 6:53 PM
Herald added a subscriber: george.burgess.iv. · View Herald Transcript
StephenFan requested review of this revision.Sep 5 2022, 6:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 5 2022, 6:53 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
StephenFan updated this revision to Diff 458077.Sep 5 2022, 6:57 PM
StephenFan retitled this revision from [MemorySSA] Simplify if condition to [MemorySSA][NFC] Simplify if condition.

Add [NFC]

Harbormaster completed remote builds in B185164: Diff 458077.Sep 5 2022, 7:37 PM
nikic accepted this revision.Sep 6 2022, 12:19 AM

LGTM

This revision is now accepted and ready to land.Sep 6 2022, 12:19 AM
Closed by commit rG2e7aed1947d2: [MemorySSA][NFC] Simplify if condition (authored by StephenFan). · Explain WhySep 6 2022, 12:47 AM
This revision was automatically updated to reflect the committed changes.
StephenFan added a commit: rG2e7aed1947d2: [MemorySSA][NFC] Simplify if condition.

Revision Contents

PathSize
llvm/
include/
llvm/
Analysis/
3 lines

Diff 458077

llvm/include/llvm/Analysis/MemorySSA.h

Show First 20 Lines • Show All 1,246 Lines • ▼ Show 20 Lines void fillInCurrentPair() {
CurrentPair.first = *DefIterator; CurrentPair.first = *DefIterator;
CurrentPair.second = Location; CurrentPair.second = Location;
if (WalkingPhi && Location.Ptr) { if (WalkingPhi && Location.Ptr) {
// Mark size as unknown, if the location is not guaranteed to be // Mark size as unknown, if the location is not guaranteed to be
// loop-invariant for any possible loop in the function. Setting the size // loop-invariant for any possible loop in the function. Setting the size
// to unknown guarantees that any memory accesses that access locations // to unknown guarantees that any memory accesses that access locations
// after the pointer are considered as clobbers, which is important to // after the pointer are considered as clobbers, which is important to
// catch loop carried dependences. // catch loop carried dependences.
if (Location.Ptr && if (!IsGuaranteedLoopInvariant(const_cast<Value *>(Location.Ptr)))
!IsGuaranteedLoopInvariant(const_cast<Value *>(Location.Ptr)))
CurrentPair.second = CurrentPair.second =
Location.getWithNewSize(LocationSize::beforeOrAfterPointer()); Location.getWithNewSize(LocationSize::beforeOrAfterPointer());
PHITransAddr Translator( PHITransAddr Translator(
const_cast<Value *>(Location.Ptr), const_cast<Value *>(Location.Ptr),
OriginalAccess->getBlock()->getModule()->getDataLayout(), nullptr); OriginalAccess->getBlock()->getModule()->getDataLayout(), nullptr);
if (!Translator.PHITranslateValue(OriginalAccess->getBlock(), if (!Translator.PHITranslateValue(OriginalAccess->getBlock(),
DefIterator.getPhiArgBlock(), DT, DefIterator.getPhiArgBlock(), DT,
▲ Show 20 Lines • Show All 100 Lines • Show Last 20 Lines