This is an archive of the discontinued LLVM Phabricator instance.

[NFC][libc++] Moves transitive includes location.
ClosedPublic

Authored by Mordante on Sep 2 2022, 8:54 AM.

Details

Reviewers
Mordante
Group Reviewers
Restricted Project
Commits
rGe31c2a1b1a64: [NFC][libc++] Moves transitive includes location.
Summary

As discussed in D132284 they will be moved to the end.

Diff Detail

Event Timeline

Mordante created this revision.Sep 2 2022, 8:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 2 2022, 8:55 AM
Mordante requested review of this revision.Sep 2 2022, 8:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 2 2022, 8:55 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Mordante accepted this revision.Sep 3 2022, 1:03 AM

The CI is happy.

This revision is now accepted and ready to land.Sep 3 2022, 1:03 AM
This revision was automatically updated to reflect the committed changes.
ldionne added a subscriber: ldionne.Sep 7 2022, 8:04 AM
ldionne added inline comments.
libcxx/include/array
532

I would have moved those to outside of the include guards for the header.

Mordante marked an inline comment as done.Oct 4 2022, 10:36 AM
Mordante added inline comments.
libcxx/include/array
532

Done in D135180.