This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Add test to ensure that type trait aliases in dependent return types can be mangled
ClosedPublic

Authored by philnik on Sep 2 2022, 4:38 AM.

Diff Detail

Event Timeline

philnik created this revision.Sep 2 2022, 4:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 2 2022, 4:38 AM
philnik requested review of this revision.Sep 2 2022, 4:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 2 2022, 4:38 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Mordante added inline comments.Sep 2 2022, 9:03 AM
libcxx/test/std/utilities/meta/meta.unary/dependent_return_type.compile.pass.cpp
10

Please add some more comment why we need to test this.

76

What selection criteria is used? For example I miss std::to_underlying.

philnik updated this revision to Diff 457671.Sep 2 2022, 12:29 PM
philnik marked an inline comment as done.
  • Addres comments
libcxx/test/std/utilities/meta/meta.unary/dependent_return_type.compile.pass.cpp
76

std::to_underlying isn't a type trait. I guess you mean std::underlying_type? If you mean that, it's checked below. All _t type traits should be checked here.

ldionne accepted this revision.Sep 15 2022, 9:06 AM
ldionne added inline comments.
libcxx/test/std/utilities/meta/meta.unary/dependent_return_type.compile.pass.cpp
11
This revision is now accepted and ready to land.Sep 15 2022, 9:06 AM