This is an archive of the discontinued LLVM Phabricator instance.

Differential D133073

[libc][bazel] split fputil into individual targets
ClosedPublic

Authored by michaelrj on Aug 31 2022, 5:06 PM.

Details

Reviewers
lntue
sivachandra
Commits
rGc5f08544e8ff: [libc][bazel] split fputil into individual targets
Summary

This matches the change made to cmake, mostly. I've left the process of
splitting the inclusions for all the math functions for a later time.

Diff Detail

Event Timeline

michaelrj created this revision.Aug 31 2022, 5:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 31 2022, 5:06 PM
Herald added subscribers: ecnelises, tschuett. · View Herald Transcript
michaelrj requested review of this revision.Aug 31 2022, 5:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 31 2022, 5:06 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B184480: Diff 457135.Aug 31 2022, 5:28 PM
sivachandra accepted this revision.Sep 1 2022, 10:30 AM
This revision is now accepted and ready to land.Sep 1 2022, 10:30 AM
lntue accepted this revision.Sep 1 2022, 10:32 AM
This revision was landed with ongoing or failed builds.Sep 1 2022, 10:59 AM
Closed by commit rGc5f08544e8ff: [libc][bazel] split fputil into individual targets (authored by michaelrj). · Explain Why
This revision was automatically updated to reflect the committed changes.
michaelrj added a commit: rGc5f08544e8ff: [libc][bazel] split fputil into individual targets.

Revision Contents

PathSize
utils/
bazel/
llvm-project-overlay/
libc/
196 lines
18 lines

Diff 457135

utils/bazel/llvm-project-overlay/libc/BUILD.bazel

Show First 20 Lines • Show All 123 Lines • ▼ Show 20 Lines deps = [
"__support_cpp_array", "__support_cpp_array",
"__support_cpp_limits", "__support_cpp_limits",
"__support_cpp_type_traits", "__support_cpp_type_traits",
":libc_root", ":libc_root",
], ],
) )
cc_library( cc_library(
name = "__support_cpp_uint128", name = "__support_uint128",
hdrs = ["src/__support/UInt128.h"], hdrs = ["src/__support/UInt128.h"],
deps = [ deps = [
":__support_uint", ":__support_uint",
":libc_root", ":libc_root",
], ],
) )
cc_library( cc_library(
Show All 11 Linescc_library(
name = "__support_str_to_integer", name = "__support_str_to_integer",
hdrs = ["src/__support/str_to_integer.h"], hdrs = ["src/__support/str_to_integer.h"],
deps = [ deps = [
":__support_cpp_limits", ":__support_cpp_limits",
":__support_ctype_utils", ":__support_ctype_utils",
], ],
) )
fputil_common_hdrs = [ cc_library(
"src/__support/FPUtil/BasicOperations.h", name = "__support_fputil_basic_operations",
"src/__support/FPUtil/DivisionAndRemainderOperations.h", hdrs = ["src/__support/FPUtil/BasicOperations.h"],
"src/__support/FPUtil/FEnvImpl.h", deps = [
"src/__support/FPUtil/FPBits.h", ":__support_cpp_type_traits",
"src/__support/FPUtil/FloatProperties.h", ":__support_fputil_fp_bits",
"src/__support/FPUtil/Hypot.h", ":libc_root",
"src/__support/FPUtil/ManipulationFunctions.h", ],
"src/__support/FPUtil/NearestIntegerOperations.h", )
"src/__support/FPUtil/NormalFloat.h",
"src/__support/FPUtil/PlatformDefs.h",
"src/__support/FPUtil/builtin_wrappers.h",
"src/__support/FPUtil/except_value_utils.h",
]
fputil_hdrs = selects.with_or({ cc_library(
"//conditions:default": fputil_common_hdrs, name = "__support_fputil_builtin_wrappers",
PLATFORM_CPU_X86_64: fputil_common_hdrs + [ hdrs = ["src/__support/FPUtil/builtin_wrappers.h"],
"src/__support/FPUtil/x86_64/LongDoubleBits.h", deps = [
"src/__support/FPUtil/x86_64/NextAfterLongDouble.h", ":libc_root",
"src/__support/FPUtil/x86_64/FEnvImpl.h", ],
)
cc_library(
name = "__support_fputil_division_and_remainder_operations",
hdrs = ["src/__support/FPUtil/DivisionAndRemainderOperations.h"],
deps = [
":__support_fputil_fp_bits",
":__support_fputil_manipulation_functions",
":__support_fputil_normal_float",
":libc_root",
], ],
PLATFORM_CPU_ARM64: fputil_common_hdrs + [ )
cc_library(
name = "__support_fputil_except_value_utils",
hdrs = ["src/__support/FPUtil/except_value_utils.h"],
deps = [
":__support_fputil_fenv_impl",
":__support_fputil_fp_bits",
":libc_root",
],
)
cc_library(
name = "__support_fputil_fenv_impl",
hdrs = ["src/__support/FPUtil/FEnvImpl.h"],
textual_hdrs = [
"src/__support/FPUtil/x86_64/FEnvImpl.h",
"src/__support/FPUtil/aarch64/FEnvImpl.h", "src/__support/FPUtil/aarch64/FEnvImpl.h",
], ],
}) deps = [
":__support_common",
":libc_root",
],
)
cc_library( cc_library(
name = "__support_fputil", name = "__support_fputil_float_properties",
hdrs = fputil_hdrs, hdrs = ["src/__support/FPUtil/FloatProperties.h"],
deps = [
":__support_fputil_platform_defs",
":__support_uint128",
":libc_root",
],
)
cc_library(
name = "__support_fputil_fp_bits",
hdrs = ["src/__support/FPUtil/FPBits.h"],
textual_hdrs = ["src/__support/FPUtil/x86_64/LongDoubleBits.h"],
deps = [ deps = [
":__support_common", ":__support_common",
":__support_cpp_bit", ":__support_cpp_bit",
":__support_cpp_type_traits", ":__support_cpp_type_traits",
":__support_cpp_uint128", ":__support_fputil_builtin_wrappers",
":__support_fputil_float_properties",
":__support_fputil_platform_defs",
":libc_root",
],
)
cc_library(
name = "__support_fputil_hypot",
hdrs = ["src/__support/FPUtil/Hypot.h"],
deps = [
":__support_cpp_bit",
":__support_cpp_type_traits",
":__support_fputil_basic_operations",
":__support_fputil_builtin_wrappers",
":__support_fputil_fenv_impl",
":__support_fputil_fp_bits",
":__support_uint128",
":libc_root",
],
)
cc_library(
name = "__support_fputil_manipulation_functions",
hdrs = ["src/__support/FPUtil/ManipulationFunctions.h"],
textual_hdrs = ["src/__support/FPUtil/x86_64/NextAfterLongDouble.h"],
deps = [
":__support_cpp_bit",
":__support_cpp_type_traits",
":__support_fputil_fp_bits",
":__support_fputil_nearest_integer_operations",
":__support_fputil_normal_float",
":__support_fputil_platform_defs",
":libc_root",
],
)
cc_library(
name = "__support_fputil_nearest_integer_operations",
hdrs = ["src/__support/FPUtil/NearestIntegerOperations.h"],
deps = [
":__support_cpp_type_traits",
":__support_fputil_fenv_impl",
":__support_fputil_fp_bits",
":libc_root",
],
)
cc_library(
name = "__support_fputil_normal_float",
hdrs = ["src/__support/FPUtil/NormalFloat.h"],
deps = [
":__support_cpp_type_traits",
":__support_fputil_fp_bits",
":libc_root",
],
)
cc_library(
name = "__support_fputil_platform_defs",
hdrs = ["src/__support/FPUtil/PlatformDefs.h"],
deps = [
":__support_common",
":libc_root", ":libc_root",
], ],
) )
sqrt_common_hdrs = [ sqrt_common_hdrs = [
"src/__support/FPUtil/sqrt.h", "src/__support/FPUtil/sqrt.h",
"src/__support/FPUtil/generic/sqrt.h", "src/__support/FPUtil/generic/sqrt.h",
"src/__support/FPUtil/generic/sqrt_80_bit_long_double.h", "src/__support/FPUtil/generic/sqrt_80_bit_long_double.h",
Show All 11 Lines
cc_library( cc_library(
name = "__support_fputil_sqrt", name = "__support_fputil_sqrt",
hdrs = sqrt_hdrs, hdrs = sqrt_hdrs,
deps = [ deps = [
":__support_common", ":__support_common",
":__support_cpp_bit", ":__support_cpp_bit",
":__support_cpp_type_traits", ":__support_cpp_type_traits",
":__support_cpp_uint128", ":__support_fputil_builtin_wrappers",
":__support_fputil", ":__support_fputil_fenv_impl",
":__support_fputil_fp_bits",
":__support_fputil_platform_defs",
":__support_uint128",
":libc_root", ":libc_root",
], ],
) )
fma_common_hdrs = [ fma_common_hdrs = [
"src/__support/FPUtil/FMA.h", "src/__support/FPUtil/FMA.h",
"src/__support/FPUtil/generic/FMA.h", "src/__support/FPUtil/generic/FMA.h",
] ]
fma_platform_hdrs = [ fma_platform_hdrs = [
"src/__support/FPUtil/x86_64/FMA.h", "src/__support/FPUtil/x86_64/FMA.h",
"src/__support/FPUtil/aarch64/FMA.h", "src/__support/FPUtil/aarch64/FMA.h",
] ]
cc_library( cc_library(
name = "__support_fputil_fma", name = "__support_fputil_fma",
hdrs = fma_common_hdrs, hdrs = fma_common_hdrs,
# These are conditionally included and will #error out if the platform # These are conditionally included and will #error out if the platform
# doesn't support FMA, so they can't be compiled on their own. # doesn't support FMA, so they can't be compiled on their own.
textual_hdrs = fma_platform_hdrs, textual_hdrs = fma_platform_hdrs,
deps = [ deps = [
":__support_common", ":__support_common",
":__support_cpp_bit", ":__support_cpp_bit",
":__support_cpp_type_traits", ":__support_cpp_type_traits",
":__support_cpp_uint128", ":__support_fputil_builtin_wrappers",
":__support_fputil", ":__support_fputil_fenv_impl",
":__support_fputil_float_properties",
":__support_fputil_fp_bits",
":__support_uint128",
":libc_root", ":libc_root",
], ],
) )
cc_library( cc_library(
name = "__support_fputil_multiply_add", name = "__support_fputil_multiply_add",
hdrs = [ hdrs = [
"src/__support/FPUtil/multiply_add.h", "src/__support/FPUtil/multiply_add.h",
▲ Show 20 Lines • Show All 53 Lines • ▼ Show 20 Lines
################################ fenv targets ################################ ################################ fenv targets ################################
libc_function( libc_function(
name = "fetestexcept", name = "fetestexcept",
srcs = ["src/fenv/fetestexcept.cpp"], srcs = ["src/fenv/fetestexcept.cpp"],
hdrs = ["src/fenv/fetestexcept.h"], hdrs = ["src/fenv/fetestexcept.h"],
deps = [ deps = [
":__support_common", ":__support_common",
":__support_fputil", ":__support_fputil_fenv_impl",
], ],
) )
libc_function( libc_function(
name = "feclearexcept", name = "feclearexcept",
srcs = ["src/fenv/feclearexcept.cpp"], srcs = ["src/fenv/feclearexcept.cpp"],
hdrs = ["src/fenv/feclearexcept.h"], hdrs = ["src/fenv/feclearexcept.h"],
deps = [ deps = [
":__support_common", ":__support_common",
":__support_fputil", ":__support_fputil_fenv_impl",
], ],
) )
libc_function( libc_function(
name = "feraiseexcept", name = "feraiseexcept",
srcs = ["src/fenv/feraiseexcept.cpp"], srcs = ["src/fenv/feraiseexcept.cpp"],
hdrs = ["src/fenv/feraiseexcept.h"], hdrs = ["src/fenv/feraiseexcept.h"],
deps = [ deps = [
":__support_common", ":__support_common",
":__support_fputil", ":__support_fputil_fenv_impl",
], ],
) )
libc_function( libc_function(
name = "fegetround", name = "fegetround",
srcs = ["src/fenv/fegetround.cpp"], srcs = ["src/fenv/fegetround.cpp"],
hdrs = ["src/fenv/fegetround.h"], hdrs = ["src/fenv/fegetround.h"],
deps = [ deps = [
":__support_common", ":__support_common",
":__support_fputil", ":__support_fputil_fenv_impl",
], ],
) )
libc_function( libc_function(
name = "fesetround", name = "fesetround",
srcs = ["src/fenv/fesetround.cpp"], srcs = ["src/fenv/fesetround.cpp"],
hdrs = ["src/fenv/fesetround.h"], hdrs = ["src/fenv/fesetround.h"],
deps = [ deps = [
":__support_common", ":__support_common",
":__support_fputil", ":__support_fputil_fenv_impl",
], ],
) )
libc_function( libc_function(
name = "fedisableexcept", name = "fedisableexcept",
srcs = ["src/fenv/fedisableexcept.cpp"], srcs = ["src/fenv/fedisableexcept.cpp"],
hdrs = ["src/fenv/fedisableexcept.h"], hdrs = ["src/fenv/fedisableexcept.h"],
deps = [ deps = [
":__support_common", ":__support_common",
":__support_fputil", ":__support_fputil_fenv_impl",
], ],
) )
libc_function( libc_function(
name = "feenableexcept", name = "feenableexcept",
srcs = ["src/fenv/feenableexcept.cpp"], srcs = ["src/fenv/feenableexcept.cpp"],
hdrs = ["src/fenv/feenableexcept.h"], hdrs = ["src/fenv/feenableexcept.h"],
deps = [ deps = [
":__support_common", ":__support_common",
":__support_fputil", ":__support_fputil_fenv_impl",
], ],
) )
libc_function( libc_function(
name = "fegetexcept", name = "fegetexcept",
srcs = ["src/fenv/fegetexcept.cpp"], srcs = ["src/fenv/fegetexcept.cpp"],
hdrs = ["src/fenv/fegetexcept.h"], hdrs = ["src/fenv/fegetexcept.h"],
deps = [ deps = [
":__support_common", ":__support_common",
":__support_fputil", ":__support_fputil_fenv_impl",
], ],
) )
libc_function( libc_function(
name = "fegetenv", name = "fegetenv",
srcs = ["src/fenv/fegetenv.cpp"], srcs = ["src/fenv/fegetenv.cpp"],
hdrs = ["src/fenv/fegetenv.h"], hdrs = ["src/fenv/fegetenv.h"],
deps = [ deps = [
":__support_common", ":__support_common",
":__support_fputil", ":__support_fputil_fenv_impl",
], ],
) )
libc_function( libc_function(
name = "fesetenv", name = "fesetenv",
srcs = ["src/fenv/fesetenv.cpp"], srcs = ["src/fenv/fesetenv.cpp"],
hdrs = ["src/fenv/fesetenv.h"], hdrs = ["src/fenv/fesetenv.h"],
deps = [ deps = [
":__support_common", ":__support_common",
":__support_fputil", ":__support_fputil_fenv_impl",
], ],
) )
libc_function( libc_function(
name = "feupdateenv", name = "feupdateenv",
srcs = ["src/fenv/feupdateenv.cpp"], srcs = ["src/fenv/feupdateenv.cpp"],
hdrs = ["src/fenv/feupdateenv.h"], hdrs = ["src/fenv/feupdateenv.h"],
deps = [ deps = [
":__support_common", ":__support_common",
":__support_fputil", ":__support_fputil_fenv_impl",
], ],
) )
libc_function( libc_function(
name = "fegetexceptflag", name = "fegetexceptflag",
srcs = ["src/fenv/fegetexceptflag.cpp"], srcs = ["src/fenv/fegetexceptflag.cpp"],
hdrs = ["src/fenv/fegetexceptflag.h"], hdrs = ["src/fenv/fegetexceptflag.h"],
deps = [ deps = [
":__support_common", ":__support_common",
":__support_fputil", ":__support_fputil_fenv_impl",
], ],
) )
libc_function( libc_function(
name = "fesetexceptflag", name = "fesetexceptflag",
srcs = ["src/fenv/fesetexceptflag.cpp"], srcs = ["src/fenv/fesetexceptflag.cpp"],
hdrs = ["src/fenv/fesetexceptflag.h"], hdrs = ["src/fenv/fesetexceptflag.h"],
deps = [ deps = [
":__support_common", ":__support_common",
":__support_fputil", ":__support_fputil_fenv_impl",
], ],
) )
libc_function( libc_function(
name = "feholdexcept", name = "feholdexcept",
srcs = ["src/fenv/feholdexcept.cpp"], srcs = ["src/fenv/feholdexcept.cpp"],
hdrs = ["src/fenv/feholdexcept.h"], hdrs = ["src/fenv/feholdexcept.h"],
deps = [ deps = [
":__support_common", ":__support_common",
":__support_fputil", ":__support_fputil_fenv_impl",
], ],
) )
################################ math targets ################################ ################################ math targets ################################
cc_library( cc_library(
name = "math_utils", name = "math_utils",
srcs = ["src/math/generic/math_utils.cpp"], srcs = ["src/math/generic/math_utils.cpp"],
Show All 17 Lines
cc_library( cc_library(
name = "range_reduction", name = "range_reduction",
hdrs = [ hdrs = [
"src/math/generic/range_reduction.h", "src/math/generic/range_reduction.h",
"src/math/generic/range_reduction_fma.h", "src/math/generic/range_reduction_fma.h",
], ],
deps = [ deps = [
":__support_fputil",
":__support_fputil_fma", ":__support_fputil_fma",
":__support_fputil_fp_bits",
":__support_fputil_multiply_add", ":__support_fputil_multiply_add",
":__support_fputil_nearest_integer", ":__support_fputil_nearest_integer",
":libc_root", ":libc_root",
], ],
) )
cc_library( cc_library(
name = "sincosf_utils", name = "sincosf_utils",
hdrs = ["src/math/generic/sincosf_utils.h"], hdrs = ["src/math/generic/sincosf_utils.h"],
deps = [ deps = [
":__support_common", ":__support_common",
":__support_fputil", ":__support_fputil_fp_bits",
":__support_fputil_polyeval", ":__support_fputil_polyeval",
":libc_root", ":libc_root",
":range_reduction", ":range_reduction",
], ],
) )
libc_math_function( libc_math_function(
name = "expm1f", name = "expm1f",
▲ Show 20 Lines • Show All 798 Lines • Show Last 20 Lines

utils/bazel/llvm-project-overlay/libc/libc_build_rules.bzl

Show First 20 Lines • Show All 73 Lines • ▼ Show 20 Linesdef libc_math_function(
specializations = specializations or ["generic"] specializations = specializations or ["generic"]
select_map = {} select_map = {}
if "generic" in specializations: if "generic" in specializations:
select_map["//conditions:default"] = ["src/math/generic/" + name + ".cpp"] select_map["//conditions:default"] = ["src/math/generic/" + name + ".cpp"]
if "aarch64" in specializations: if "aarch64" in specializations:
select_map[PLATFORM_CPU_ARM64] = ["src/math/aarch64/" + name + ".cpp"] select_map[PLATFORM_CPU_ARM64] = ["src/math/aarch64/" + name + ".cpp"]
if "x86_64" in specializations: if "x86_64" in specializations:
select_map[PLATFORM_CPU_X86_64] = ["src/math/x86_64/" + name + ".cpp"] select_map[PLATFORM_CPU_X86_64] = ["src/math/x86_64/" + name + ".cpp"]
#TODO(michaelrj): Fix the floating point dependencies
OLD_FPUTIL_DEPS = [
":__support_fputil_basic_operations",
":__support_fputil_division_and_remainder_operations",
":__support_fputil_fenv_impl",
":__support_fputil_fp_bits",
":__support_fputil_float_properties",
":__support_fputil_hypot",
":__support_fputil_manipulation_functions",
":__support_fputil_nearest_integer_operations",
":__support_fputil_normal_float",
":__support_fputil_platform_defs",
":__support_fputil_builtin_wrappers",
":__support_fputil_except_value_utils",
]
libc_function( libc_function(
name = name, name = name,
srcs = selects.with_or(select_map), srcs = selects.with_or(select_map),
hdrs = ["src/math/" + name + ".h"], hdrs = ["src/math/" + name + ".h"],
deps = [":__support_common", ":__support_fputil"] + additional_deps, deps = [":__support_common"] + OLD_FPUTIL_DEPS + additional_deps,
) )