Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

[tosa] Add legalization for conv3d

Authored by tatwaichong on Aug 31 2022, 3:32 PM.



Update the existing implementation to match TOSA spec.

Diff Detail

Event Timeline

tatwaichong created this revision.Aug 31 2022, 3:32 PM
Herald added a project: Restricted Project. · View Herald Transcript
tatwaichong requested review of this revision.Aug 31 2022, 3:32 PM
tatwaichong edited the summary of this revision. (Show Details)Oct 6 2022, 11:17 AM
rsuderman added inline comments.Oct 6 2022, 11:21 AM

Could you change the outputShape[4] == -1 to ShapedType::isDynamic(outputShape[4]).

Instead of comparing with -1, change to use ShapedType::isDynamic

tatwaichong marked an inline comment as done.Oct 6 2022, 11:59 AM
rsuderman accepted this revision.Oct 6 2022, 12:49 PM
This revision is now accepted and ready to land.Oct 6 2022, 12:49 PM
This revision was automatically updated to reflect the committed changes.