This is an archive of the discontinued LLVM Phabricator instance.

[msan] Add more specific messages for use-after-destroy
ClosedPublic

Authored by vitalybuka on Aug 29 2022, 6:56 PM.

Diff Detail

Event Timeline

vitalybuka created this revision.Aug 29 2022, 6:56 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 29 2022, 6:56 PM
Herald added a subscriber: Enna1. · View Herald Transcript
vitalybuka requested review of this revision.Aug 29 2022, 6:56 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptAug 29 2022, 6:56 PM
Herald added subscribers: Restricted Project, cfe-commits. · View Herald Transcript
kstoimenov accepted this revision.Aug 30 2022, 3:14 PM
kstoimenov added inline comments.
clang/lib/CodeGen/CGClass.cpp
1773–1774

Should this be a constant?

This revision is now accepted and ready to land.Aug 30 2022, 3:14 PM
kda accepted this revision.Aug 30 2022, 3:30 PM
vitalybuka added inline comments.Aug 30 2022, 7:52 PM
clang/lib/CodeGen/CGClass.cpp
1773–1774

it would be nice if we can share constants with runtime, but as is clang/compiler-rt do not include each other
without reuse I don't see a point in named constant.