This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Use the NativeSock type instead of plain 'int'
ClosedPublic

Authored by mstorsjo on Aug 29 2022, 3:29 AM.

Details

Summary

This fixes a warning when building for Windows:

../tools/lldb/source/Host/common/TCPSocket.cpp:297:16: warning: comparison of integers of different signs: 'int' and 'const NativeSocket' (aka 'const unsigned long long') [-Wsign-compare]
      if (sock != kInvalidSocketValue) {
          ~~~~ ^  ~~~~~~~~~~~~~~~~~~~

Diff Detail

Event Timeline

mstorsjo created this revision.Aug 29 2022, 3:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 29 2022, 3:29 AM
mstorsjo requested review of this revision.Aug 29 2022, 3:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 29 2022, 3:29 AM
fixathon accepted this revision.Aug 29 2022, 3:45 AM

LGTM, thanks for the fix!

This revision is now accepted and ready to land.Aug 29 2022, 3:45 AM
This revision was automatically updated to reflect the committed changes.