This is an archive of the discontinued LLVM Phabricator instance.

[NFC][libc] Move Uint implementation to parent directory
ClosedPublic

Authored by gchatelet on Aug 25 2022, 2:09 AM.

Diff Detail

Event Timeline

gchatelet created this revision.Aug 25 2022, 2:09 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptAug 25 2022, 2:09 AM
gchatelet requested review of this revision.Aug 25 2022, 2:09 AM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 25 2022, 5:42 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
orex added a subscriber: orex.Aug 28 2022, 7:01 AM
orex added inline comments.
libc/test/src/CMakeLists.txt
34

Hello. Sorry for disturbing in closed review, but commenting this line completely disable all math tests in LLVM for me. Can you provide any additional verification that this is really necessary and math tests should be enabled somehow in a different way?

sivachandra added inline comments.
libc/test/src/CMakeLists.txt
34

Oh. Shoot! Thx for catching it @orex and for the fix @sivachandra .

libc/src/__support/UInt.h