User Details
- User Since
- Jun 4 2022, 3:39 AM (68 w, 4 d)
Nov 4 2022
Another question to you is how the functions will work with implicit conversion. What I would do is to force input be the same with is_same of enable_if, if they are available.
Oct 28 2022
Oct 27 2022
Sep 17 2022
Sep 16 2022
Sep 15 2022
Sep 14 2022
Sep 9 2022
Sep 7 2022
Good job, Tue!
Aug 30 2022
Review fixes.
Review fixes.
The aux functions are split into two files according @lntue suggestion.
Review fixes.
Aug 29 2022
Fixed entrypoint.
Fixed comments.
Fix wrong upload.
Constants description added.
Thank you, Paul! I'll land the revision after Tue review.
Aug 28 2022
Aug 12 2022
Aug 11 2022
Aug 4 2022
Aug 3 2022
Aug 1 2022
Jul 29 2022
Paul (@zimmermann6) and Tue (@lntue),
Rebased to latest main.
Thank you Paul for sharing the results.
The results I got using the same compiler (llvm 11) as Paul (@zimmermann6):
CORE_MATH_PERF_MODE=rdtsc PERF_ARGS='' ./perf.sh coshf GNU libc version: 2.31 GNU libc release: stable 18.534 13.019 17.590 CORE_MATH_PERF_MODE=rdtsc PERF_ARGS='--latency' ./perf.sh coshf GNU libc version: 2.31 GNU libc release: stable 49.670 38.334 50.461
As you can see llvm 12 significantly improve throughput of this version of coshf over version 11. Partially this problem can be explained by this difference. Another source of the difference is Intel vs AMD. We observe such difference with (@lntue).
Paul, can you confirm, that the precision is OK? I think that we can push the changes even though the solution is not the fastest for all platforms/compilers? Tue?
Jul 28 2022
Review fixes.
Review fixes.
Review fixes. More verbose comments.
Review fixes.
Rebasing on main with small fixes.
Rebasing on main with small fixes.
Merged to last main, some cosmetic changes.
Jul 27 2022
Small fixes in test.
Small fixes.
OK. Thanks! let's wait.
Added explicit dependencies.
Improved performance by fputil::nearest_integer function.
Jul 12 2022
The easiest way, from my point of view, will be to apply it on top of working coshf branch, which you made and test.
Can you try to put all the chain on top of the revision 60d6be5dd3f411cfe1b5392cbb... for now. I'll rebase the revisions to the last main tonight.
Jul 7 2022
Jul 6 2022
Jul 1 2022
Fix some reviewer comments.
Jun 30 2022
Fix build problem.
Jun 29 2022
Added sinhf/coshf