User Details
- User Since
- Jun 4 2022, 3:39 AM (10 w, 4 d)
Fri, Aug 12
Thu, Aug 11
Thu, Aug 4
Wed, Aug 3
Mon, Aug 1
Fri, Jul 29
Paul (@zimmermann6) and Tue (@lntue),
Rebased to latest main.
Thank you Paul for sharing the results.
The results I got using the same compiler (llvm 11) as Paul (@zimmermann6):
CORE_MATH_PERF_MODE=rdtsc PERF_ARGS='' ./perf.sh coshf GNU libc version: 2.31 GNU libc release: stable 18.534 13.019 17.590 CORE_MATH_PERF_MODE=rdtsc PERF_ARGS='--latency' ./perf.sh coshf GNU libc version: 2.31 GNU libc release: stable 49.670 38.334 50.461
As you can see llvm 12 significantly improve throughput of this version of coshf over version 11. Partially this problem can be explained by this difference. Another source of the difference is Intel vs AMD. We observe such difference with (@lntue).
Paul, can you confirm, that the precision is OK? I think that we can push the changes even though the solution is not the fastest for all platforms/compilers? Tue?
Thu, Jul 28
Review fixes.
Review fixes.
Review fixes. More verbose comments.
Review fixes.
Rebasing on main with small fixes.
Rebasing on main with small fixes.
Merged to last main, some cosmetic changes.
Wed, Jul 27
Small fixes in test.
Small fixes.
OK. Thanks! let's wait.
Added explicit dependencies.
Improved performance by fputil::nearest_integer function.
Jul 12 2022
The easiest way, from my point of view, will be to apply it on top of working coshf branch, which you made and test.
Can you try to put all the chain on top of the revision 60d6be5dd3f411cfe1b5392cbb... for now. I'll rebase the revisions to the last main tonight.
Jul 7 2022
Jul 6 2022
Jul 1 2022
Fix some reviewer comments.
Jun 30 2022
Fix build problem.
Jun 29 2022
Added sinhf/coshf
Jun 27 2022
Jun 24 2022
Changed unsafe_clz to safe_clz in string_to_float.h
unsafe ctz/clz
Tue. I think, if we will not find agreement with ctz/clz syntax, we can ask Siva to solve the problem. Also, as long as you will use the function in the next changes, you can also try them and if it will not work good, improve it.
Tests polishing.
Thank you Tue, for your comments. They was really useful. I'll really appreciate if you go through all my replies. It was a lot of them, so I'm afraid that I can miss something or my changes can be improved even more. I'll also appreciate if you check the performance for fmod in the same way, as other functions. I've attached the file
. You should simply unpack it inside core-math folder.Cosmetic changes: veriable renaming, docs update etc.
Jun 22 2022
Some cosmetic changes.
Jun 21 2022
Jun 16 2022
Jun 13 2022
C standard/Posix processing of special numbers.
Jun 10 2022
cerrno fix.
Rebasing changes on last main.
Jun 9 2022
Jun 7 2022
Update static_assert message.
Jun 6 2022
Fixed header protection name.
Added EXP_MANT_MASK.