This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt][hwasan] Introduce MaybeFailWithoutTaggingAbi()
ClosedPublic

Authored by glider on Aug 24 2022, 3:26 AM.

Details

Summary

Use a helper function to print an error message and die in the case
flags()->fail_without_syscall_abi is set.

Because x86 doesn't have sysctl abi.tagged_addr_disabled, do not
mention it in the error message for non-Android runtime.

Depends on D132543

Diff Detail

Event Timeline

glider created this revision.Aug 24 2022, 3:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 24 2022, 3:26 AM
glider requested review of this revision.Aug 24 2022, 3:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 24 2022, 3:26 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
kstoimenov accepted this revision.Aug 24 2022, 1:29 PM
kstoimenov added inline comments.
compiler-rt/lib/hwasan/hwasan_linux.cpp
113

Could be DieIfNoTaggingAbi.

This revision is now accepted and ready to land.Aug 24 2022, 1:29 PM
vitalybuka accepted this revision.Aug 24 2022, 2:18 PM
glider updated this revision to Diff 455500.Aug 25 2022, 1:31 AM

Rename MaybeFailWithoutTaggingAbi() to MaybeDieIfNoTaggingAbi()

This revision was landed with ongoing or failed builds.Aug 25 2022, 1:32 AM
This revision was automatically updated to reflect the committed changes.