Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

[Flang]Fix another way to crash SimplifyIntrinsics
ClosedPublic
Actions

Authored by Leporacanthicus on Aug 19 2022, 8:31 AM.

Details

Reviewers

kiranchandramohan
DylanFleming-arm
vzakhari

Commits

rG72e599197c77: [Flang]Fix another way to crash SimplifyIntrinsics

Summary

Under some conditions, the defining op may be NULL, so
accept that rahter than try to use it and crash!

Adds test to prevent regression

Fixes github issue #57201

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

Leporacanthicus created this revision.Aug 19 2022, 8:31 AM

Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptAug 19 2022, 8:31 AM

Herald added a subscriber: mehdi_amini. · View Herald Transcript

Leporacanthicus requested review of this revision.Aug 19 2022, 8:31 AM

Herald added a subscriber: jdoerfert. · View Herald TranscriptAug 19 2022, 8:31 AM

Leporacanthicus added reviewers: kiranchandramohan, DylanFleming-arm, vzakhari.Aug 19 2022, 8:38 AM

Harbormaster completed remote builds in B182233: Diff 454016.Aug 19 2022, 9:07 AM

LGTM

This revision is now accepted and ready to land.Aug 19 2022, 9:17 AM

Closed by commit rG72e599197c77: [Flang]Fix another way to crash SimplifyIntrinsics (authored by MatsPetersson). · Explain WhyAug 19 2022, 11:00 AM

This revision was automatically updated to reflect the committed changes.

MatsPetersson added a commit: rG72e599197c77: [Flang]Fix another way to crash SimplifyIntrinsics.

Revision Contents
Changeset List

Path

Size

flang/

lib/

Optimizer/

Transforms/

SimplifyIntrinsics.cpp

4 lines

test/

Transforms/

simplifyintrinsics.fir

31 lines

Diff 454065

View Options

flang/lib/Optimizer/Transforms/SimplifyIntrinsics.cpp