Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
LGTM except the nit.
llvm/test/CodeGen/LoongArch/bnez-beqz.ll | ||
---|---|---|
8 | Isn't the "testcase name" misleading? It certainly is meant to exercise the bnez pattern with i32 icmp, so it could be better to name it bnez_i32 instead. Same with other cases. |
llvm/test/CodeGen/LoongArch/bnez-beqz.ll | ||
---|---|---|
8 | Thanks, I will change that. |
Isn't the "testcase name" misleading? It certainly is meant to exercise the bnez pattern with i32 icmp, so it could be better to name it bnez_i32 instead.
Same with other cases.