This is an archive of the discontinued LLVM Phabricator instance.

[LoongArch] Supports brcond with 21 bit offsets
ClosedPublic

Authored by gonglingqin on Aug 16 2022, 8:09 PM.

Diff Detail

Event Timeline

gonglingqin created this revision.Aug 16 2022, 8:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 16 2022, 8:09 PM
gonglingqin requested review of this revision.Aug 16 2022, 8:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 16 2022, 8:09 PM
xen0n added a comment.Aug 16 2022, 8:14 PM

LGTM except the nit.

llvm/test/CodeGen/LoongArch/bnez-beqz.ll
8

Isn't the "testcase name" misleading? It certainly is meant to exercise the bnez pattern with i32 icmp, so it could be better to name it bnez_i32 instead.

Same with other cases.

gonglingqin added inline comments.Aug 16 2022, 8:24 PM
llvm/test/CodeGen/LoongArch/bnez-beqz.ll
8

Thanks, I will change that.

Address @xen0n's comments.

This revision is now accepted and ready to land.Aug 16 2022, 8:30 PM
This revision was automatically updated to reflect the committed changes.