This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Make sure that aggregate shared libraries define all of their symbols.
ClosedPublic

Authored by stellaraccident on Aug 15 2022, 11:21 AM.

Details

Summary

We were hitting issues on Linux where this was only being caught at runtime, and different linkers (BFD vs LLD) are differently strict in such situations. Such libraries will also fail to build properly on Windows (but test coverage of that is limited, so it is better to enforce globally).

Diff Detail

Event Timeline

stellaraccident requested review of this revision.Aug 15 2022, 11:21 AM
mehdi_amini accepted this revision.Aug 15 2022, 11:25 AM
This revision is now accepted and ready to land.Aug 15 2022, 11:25 AM
This revision was landed with ongoing or failed builds.Aug 15 2022, 12:02 PM
This revision was automatically updated to reflect the committed changes.