[BOLT][NFC] Simplify addRelocation

[Amir]

Summary

Move the implementation out of the header file.
Simplify the method.
Add debug logging.

[rafauler]

LGTM

[Amir]

clang-format, formatv

[Amir]

Reverting emplace/move ctor behavior

bolt/include/bolt/Core/BinarySection.h

 //===- bolt/Core/BinarySection.h - Section in a binary file -----*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 //
bool removeRelocationAt(uint64_t Offset) {
     }
     return false;
   }
 
   void clearRelocations();
 
   /// Add a new relocation at the given /p Offset.
   void addRelocation(uint64_t Offset, MCSymbol *Symbol, uint64_t Type,
-                     uint64_t Addend, uint64_t Value = 0,
-                     bool Pending = false) {
-    assert(Offset < getSize() && "offset not within section bounds");
-    if (!Pending) {
-      Relocations.emplace(Relocation{Offset, Symbol, Type, Addend, Value});
-    } else {
-      PendingRelocations.emplace_back(
-          Relocation{Offset, Symbol, Type, Addend, Value});
-    }
-  }
+                     uint64_t Addend, uint64_t Value = 0, bool Pending = false);
 
   /// Add a dynamic relocation at the given /p Offset.
   void addDynamicRelocation(uint64_t Offset, MCSymbol *Symbol, uint64_t Type,
                             uint64_t Addend, uint64_t Value = 0) {
     assert(Offset < getSize() && "offset not within section bounds");
     DynamicRelocations.emplace(Relocation{Offset, Symbol, Type, Addend, Value});
   }
 

bolt/lib/Core/BinarySection.cpp

 //===- bolt/Core/BinarySection.cpp - Section in a binary file -------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 //
if (!isAllocatable() &&
       (!hasSectionRef() ||
        OutputContents.data() != getContents(Section).data())) {
     delete[] getOutputData();
   }
 }
 
 void BinarySection::clearRelocations() { clearList(Relocations); }
 
+void BinarySection::addRelocation(uint64_t Offset, MCSymbol *Symbol,
+                                  uint64_t Type, uint64_t Addend,
+                                  uint64_t Value, bool Pending) {
+  assert(Offset < getSize() && "offset not within section bounds");
+  LLVM_DEBUG(dbgs() << formatv(
+                 "BOLT-DEBUG: addRelocation in {0}, @{1:x} against {2}\n",
+                 getName(), Offset, Symbol->getName()));
+  if (Pending) {
+    PendingRelocations.emplace_back(
+        Relocation{Offset, Symbol, Type, Addend, Value});
+  } else {
+    Relocations.emplace(Relocation{Offset, Symbol, Type, Addend, Value});
+  }
+}
+
 void BinarySection::print(raw_ostream &OS) const {
   OS << getName() << ", "
      << "0x" << Twine::utohexstr(getAddress()) << ", " << getSize() << " (0x"
      << Twine::utohexstr(getOutputAddress()) << ", " << getOutputSize() << ")"
      << ", data = " << getData() << ", output data = " << getOutputData();
 
   if (isAllocatable())
     OS << " (allocatable)";