This is an archive of the discontinued LLVM Phabricator instance.

[mlir][tosa] Update TOSA resize to match specification
ClosedPublic

Authored by tatwaichong on Aug 10 2022, 3:46 PM.

Details

Summary

Attribute stride and shift are removed, and has new scale and border.

Signed-off-by: TatWai Chong <tatwai.chong@arm.com>
Change-Id: I6cdbeb3978f5ee540bc6cf59eb7c273eb0131430

Diff Detail

Event Timeline

tatwaichong created this revision.Aug 10 2022, 3:46 PM
Herald added a project: Restricted Project. · View Herald Transcript
tatwaichong requested review of this revision.Aug 10 2022, 3:46 PM

Rebase and resolve conflicts

rsuderman requested changes to this revision.Aug 23 2022, 1:57 PM
rsuderman added a subscriber: rsuderman.
rsuderman added inline comments.
mlir/lib/Dialect/Tosa/IR/TosaOps.cpp
820

You need to check for dynamic shapes. this assumes the inHeight is always guaranteed to be static which is not technically guaranteed in the IR

This revision now requires changes to proceed.Aug 23 2022, 1:57 PM

Add check whether input tensor is dynamic shape.

rsuderman accepted this revision.Oct 5 2022, 12:46 PM
This revision is now accepted and ready to land.Oct 5 2022, 12:46 PM
This revision was automatically updated to reflect the committed changes.