Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D131629

[mlir][tosa] Update TOSA resize to match specification
ClosedPublic
Actions

Authored by tatwaichong on Aug 10 2022, 3:46 PM.

Details

Reviewers
sjarus
rsuderman
nicolasvasilache
Commits
rGff23599a0dfc: [mlir][tosa] Update TOSA resize to match specification
Summary

Attribute stride and shift are removed, and has new scale and border.

Signed-off-by: TatWai Chong <tatwai.chong@arm.com>
Change-Id: I6cdbeb3978f5ee540bc6cf59eb7c273eb0131430

Diff Detail

Event Timeline

tatwaichong created this revision.Aug 10 2022, 3:46 PM
Herald added a reviewer: sjarus. · View Herald TranscriptAug 10 2022, 3:46 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: bzcheeseman, sdasgup3, wenzhicui and 23 others. · View Herald Transcript
tatwaichong requested review of this revision.Aug 10 2022, 3:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 10 2022, 3:46 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B180548: Diff 451663.Aug 10 2022, 3:47 PM
tatwaichong updated this revision to Diff 453215.Aug 17 2022, 12:50 AM

Rebase and resolve conflicts

Harbormaster completed remote builds in B181691: Diff 453215.Aug 17 2022, 1:07 AM
rsuderman requested changes to this revision.Aug 23 2022, 1:57 PM
rsuderman added a subscriber: rsuderman.
rsuderman added inline comments.
mlir/lib/Dialect/Tosa/IR/TosaOps.cpp
820

You need to check for dynamic shapes. this assumes the inHeight is always guaranteed to be static which is not technically guaranteed in the IR

This revision now requires changes to proceed.Aug 23 2022, 1:57 PM
tatwaichong updated this revision to Diff 464152.Sep 29 2022, 11:49 PM

Add check whether input tensor is dynamic shape.

Herald added a reviewer: nicolasvasilache. · View Herald TranscriptSep 29 2022, 11:49 PM
Herald added a subscriber: zero9178. · View Herald Transcript
Harbormaster completed remote builds in B189601: Diff 464152.Sep 30 2022, 12:08 AM
rsuderman accepted this revision.Oct 5 2022, 12:46 PM
This revision is now accepted and ready to land.Oct 5 2022, 12:46 PM
Closed by commit rGff23599a0dfc: [mlir][tosa] Update TOSA resize to match specification (authored by tatwaichong, committed by rsuderman). · Explain WhyOct 5 2022, 1:20 PM
This revision was automatically updated to reflect the committed changes.
rsuderman added a commit: rGff23599a0dfc: [mlir][tosa] Update TOSA resize to match specification.

Revision Contents
Changeset List

PathSize
mlir/
include/
mlir/
Dialect/
Tosa/
IR/
15 lines
lib/
Conversion/
TosaToLinalg/
179 lines
Dialect/
Tosa/
IR/
82 lines
test/
Conversion/
TosaToLinalg/
514 lines
Dialect/
Tosa/
2 lines
66 lines

Diff 465525

View Options

mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td

Loading...
View Options

mlir/lib/Conversion/TosaToLinalg/TosaToLinalg.cpp

Loading...
View Options

mlir/lib/Dialect/Tosa/IR/TosaOps.cpp

Loading...
View Options

mlir/test/Conversion/TosaToLinalg/tosa-to-linalg.mlir

Loading...
View Options

mlir/test/Dialect/Tosa/ops.mlir

Loading...
View Options

mlir/test/Dialect/Tosa/tosa-infer-shapes.mlir

Loading...