This is an archive of the discontinued LLVM Phabricator instance.

Differential D131621

[mlir][sparse][bf16] disable two bf16 tests
ClosedPublic

Authored by aartbik on Aug 10 2022, 2:41 PM.

Details

Reviewers
bixia
mehdi_amini
Commits
rG6b7459115f7b: [mlir][sparse][bf16] disable two bf16 tests
Summary

Supposedly our ABI issues were fixed, per issue:
https://github.com/llvm/llvm-project/issues/55992

However, with a recent changes to bf16, these tests
fail again; not sure why yet:
https://reviews.llvm.org/D130832
https://lab.llvm.org/buildbot/#/builders/61/builds/30600

So we disable the tests for now. Issue is tracked in:
https://github.com/llvm/llvm-project/issues/57042

Diff Detail

Event Timeline

aartbik created this revision.Aug 10 2022, 2:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 10 2022, 2:41 PM
Herald added subscribers: anlunx, bzcheeseman, sdasgup3 and 17 others. · View Herald Transcript
aartbik requested review of this revision.Aug 10 2022, 2:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 10 2022, 2:41 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
aartbik updated this revision to Diff 451637.Aug 10 2022, 2:44 PM

removed dangling Z (vi much?)

aartbik updated this revision to Diff 451647.Aug 10 2022, 3:02 PM

XFAIL -> UNSUPPORTED

aartbik edited the summary of this revision. (Show Details)Aug 10 2022, 3:41 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 10 2022, 3:50 PM
This revision was landed with ongoing or failed builds.
Closed by commit rG6b7459115f7b: [mlir][sparse][bf16] disable two bf16 tests (authored by aartbik). · Explain Why
This revision was automatically updated to reflect the committed changes.
aartbik added a commit: rG6b7459115f7b: [mlir][sparse][bf16] disable two bf16 tests.
Harbormaster completed remote builds in B180535: Diff 451647.Aug 10 2022, 4:57 PM

Revision Contents

PathSize
mlir/
test/
Integration/
Dialect/
SparseTensor/
CPU/
3 lines
3 lines

Diff 451665

mlir/test/Integration/Dialect/SparseTensor/CPU/dense_output_bf16.mlir

// FIXME: see #57042
// UNSUPPORTED: i386, x86_64
// RUN: mlir-opt %s --sparse-compiler | \ // RUN: mlir-opt %s --sparse-compiler | \
// RUN: mlir-cpu-runner \ // RUN: mlir-cpu-runner \
// RUN: -e entry -entry-point-result=void \ // RUN: -e entry -entry-point-result=void \
// RUN: -shared-libs=%mlir_integration_test_dir/libmlir_c_runner_utils%shlibext | \ // RUN: -shared-libs=%mlir_integration_test_dir/libmlir_c_runner_utils%shlibext | \
// RUN: FileCheck %s // RUN: FileCheck %s
#SparseVector = #sparse_tensor.encoding<{dimLevelType = ["compressed"]}> #SparseVector = #sparse_tensor.encoding<{dimLevelType = ["compressed"]}>
#DenseVector = #sparse_tensor.encoding<{dimLevelType = ["dense"]}> #DenseVector = #sparse_tensor.encoding<{dimLevelType = ["dense"]}>
▲ Show 20 Lines • Show All 82 Lines • Show Last 20 Lines

mlir/test/Integration/Dialect/SparseTensor/CPU/sparse_sum_bf16.mlir

// FIXME: see #57042
// UNSUPPORTED: i386, x86_64
// RUN: mlir-opt %s --sparse-compiler | \ // RUN: mlir-opt %s --sparse-compiler | \
// RUN: mlir-cpu-runner \ // RUN: mlir-cpu-runner \
// RUN: -e entry -entry-point-result=void \ // RUN: -e entry -entry-point-result=void \
// RUN: -shared-libs=%mlir_integration_test_dir/libmlir_c_runner_utils%shlibext | \ // RUN: -shared-libs=%mlir_integration_test_dir/libmlir_c_runner_utils%shlibext | \
// RUN: FileCheck %s // RUN: FileCheck %s
!Filename = !llvm.ptr<i8> !Filename = !llvm.ptr<i8>
▲ Show 20 Lines • Show All 66 Lines • Show Last 20 Lines