This is an archive of the discontinued LLVM Phabricator instance.

Differential D131496

[mlir][tosa] Updates tosa.logical_not to use the SameOperandsAndResultType trait
ClosedPublic

Authored by not-jenni on Aug 9 2022, 7:21 AM.

Details

Reviewers
sjarus
jpienaar
Commits
rG7ff0ca1a4df8: [mlir][tosa] Updates tosa.logical_not to use the SameOperandsAndResultType trait

Diff Detail

Event Timeline

not-jenni created this revision.Aug 9 2022, 7:21 AM
Herald added a reviewer: sjarus. · View Herald TranscriptAug 9 2022, 7:21 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: bzcheeseman, sdasgup3, wenzhicui and 21 others. · View Herald Transcript
not-jenni requested review of this revision.Aug 9 2022, 7:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 9 2022, 7:21 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
not-jenni added a reviewer: jpienaar.Aug 9 2022, 7:21 AM
jpienaar added a comment.Aug 9 2022, 7:25 AM

Is this due to shape mismatches?

not-jenni added a comment.Aug 9 2022, 9:05 AM
In D131496#3709763, @jpienaar wrote:

Is this due to shape mismatches?

This is useful so that the return type does not need to be specified when creating a tosa.logical_not op in PDLL

jpienaar accepted this revision.Aug 9 2022, 9:25 AM

Ug, sorry read on mobile first and read the not as removing the trait and I couldn't figure out why.

This revision is now accepted and ready to land.Aug 9 2022, 9:25 AM
Harbormaster completed remote builds in B180165: Diff 451141.Aug 9 2022, 9:37 AM
not-jenni updated this revision to Diff 451539.Aug 10 2022, 10:11 AM

Remove a test for inferring shapes with logical_not as it is no longer needed

Harbormaster completed remote builds in B180453: Diff 451539.Aug 10 2022, 1:24 PM
Closed by commit rG7ff0ca1a4df8: [mlir][tosa] Updates tosa.logical_not to use the SameOperandsAndResultType trait (authored by not-jenni, committed by jpienaar). · Explain WhyAug 11 2022, 3:53 PM
This revision was automatically updated to reflect the committed changes.
jpienaar added a commit: rG7ff0ca1a4df8: [mlir][tosa] Updates tosa.logical_not to use the SameOperandsAndResultType trait.

Revision Contents

PathSize
mlir/
include/
mlir/
Dialect/
Tosa/
IR/
2 lines
test/
Dialect/
Tosa/
9 lines

Diff 451539

mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td

Show First 20 Lines • Show All 1,007 Lines • ▼ Show 20 Lines
} }
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// Operator: logical_not // Operator: logical_not
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
def Tosa_LogicalNotOp : Tosa_Op<"logical_not", [ def Tosa_LogicalNotOp : Tosa_Op<"logical_not", [
DeclareOpInterfaceMethods<InferShapedTypeOpInterface, DeclareOpInterfaceMethods<InferShapedTypeOpInterface,
["inferReturnTypeComponents"]>, ["inferReturnTypeComponents"]>,
NoSideEffect]> { NoSideEffect, SameOperandsAndResultType]> {
let summary = "Returns the truth value of NOT x element-wise."; let summary = "Returns the truth value of NOT x element-wise.";
let description = [{ let description = [{
Elementwise logical NOT of input. Elementwise logical NOT of input.
}]; }];
let arguments = (ins let arguments = (ins
I1Tensor:$input1 I1Tensor:$input1
▲ Show 20 Lines • Show All 864 Lines • Show Last 20 Lines

mlir/test/Dialect/Tosa/tosa-infer-shapes.mlir

Show First 20 Lines • Show All 100 Lines • ▼ Show 20 Linesfunc.func @test_unary_i32(%arg0 : tensor<4xi32>) -> () {
// CHECK: "tosa.identity"(%arg0) : (tensor<4xi32>) -> tensor<4xi32> // CHECK: "tosa.identity"(%arg0) : (tensor<4xi32>) -> tensor<4xi32>
%8 = "tosa.identity"(%arg0) : (tensor<4xi32>) -> tensor<?xi32> %8 = "tosa.identity"(%arg0) : (tensor<4xi32>) -> tensor<?xi32>
return return
} }
// ----- // -----
// CHECK-LABEL: @test_unary_i1
func.func @test_unary_i1(%arg0 : tensor<4xi1>) -> () {
// CHECK: "tosa.logical_not"(%arg0) : (tensor<4xi1>) -> tensor<4xi1>
%0 = "tosa.logical_not"(%arg0) : (tensor<4xi1>) -> tensor<*xi1>
return
}
// -----
// CHECK-LABEL: @test_binary_scalar_f32 // CHECK-LABEL: @test_binary_scalar_f32
func.func @test_binary_scalar_f32(%arg0 : tensor<4xf32>, %arg1 : tensor<f32>) -> () { func.func @test_binary_scalar_f32(%arg0 : tensor<4xf32>, %arg1 : tensor<f32>) -> () {
// CHECK: "tosa.add"(%arg0, %arg1) : (tensor<4xf32>, tensor<f32>) -> tensor<4xf32> // CHECK: "tosa.add"(%arg0, %arg1) : (tensor<4xf32>, tensor<f32>) -> tensor<4xf32>
%0 = "tosa.add"(%arg0, %arg1) : (tensor<4xf32>, tensor<f32>) -> tensor<*xf32> %0 = "tosa.add"(%arg0, %arg1) : (tensor<4xf32>, tensor<f32>) -> tensor<*xf32>
// CHECK: "tosa.maximum"(%arg0, %arg1) : (tensor<4xf32>, tensor<f32>) -> tensor<4xf32> // CHECK: "tosa.maximum"(%arg0, %arg1) : (tensor<4xf32>, tensor<f32>) -> tensor<4xf32>
%1 = "tosa.maximum"(%arg0, %arg1) : (tensor<4xf32>, tensor<f32>) -> tensor<*xf32> %1 = "tosa.maximum"(%arg0, %arg1) : (tensor<4xf32>, tensor<f32>) -> tensor<*xf32>
▲ Show 20 Lines • Show All 1,062 Lines • Show Last 20 Lines