This is an archive of the discontinued LLVM Phabricator instance.

[libclc] Quote addition of CLC/LLAsm flags
ClosedPublic

Authored by nikic on Aug 9 2022, 5:57 AM.

Details

Summary

Otherwise cmake will insert a semicolon if flags are already set.

Diff Detail

Event Timeline

nikic created this revision.Aug 9 2022, 5:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 9 2022, 5:57 AM
Herald added a subscriber: mgorny. · View Herald Transcript
nikic requested review of this revision.Aug 9 2022, 5:57 AM
Ericson2314 accepted this revision.Aug 30 2022, 1:07 PM

Might it be better to stort as a CMake list internally and then convert at only when used?

This revision is now accepted and ready to land.Aug 30 2022, 1:07 PM
nikic added a comment.Aug 31 2022, 1:33 AM

Might it be better to stort as a CMake list internally and then convert at only when used?

Is that typically done for CFLAGS-style variables? Seems a bit odd to me to not keep these literal.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 31 2022, 2:10 AM

This patch breaks formatting. If there's a spaces after opening "(" there should be one before closing ")"