This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Implement `operator<=>` for `error_{code,condition}`
ClosedPublic

Authored by avogelsgesang on Aug 7 2022, 3:08 PM.

Details

Summary

Implements part of P1614R2 "The Mothership has Landed"

Diff Detail

Event Timeline

avogelsgesang created this revision.Aug 7 2022, 3:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 7 2022, 3:08 PM
avogelsgesang requested review of this revision.Aug 7 2022, 3:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 7 2022, 3:08 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript

Update review link and fix synopsis in test files

Mordante accepted this revision.Aug 14 2022, 10:10 AM

LGTM module some nits.

libcxx/include/system_error
456
460

Please format the new code so return is placed properly.

This revision is now accepted and ready to land.Aug 14 2022, 10:10 AM
avogelsgesang marked 2 inline comments as done.

address comments. waiting for CI before landing this

This revision was landed with ongoing or failed builds.Aug 15 2022, 4:06 PM
This revision was automatically updated to reflect the committed changes.