This is an archive of the discontinued LLVM Phabricator instance.

libclc: Allow building with only required LLVM libs and with custom CLC/LLAsm flags
ClosedPublic

Authored by callumfare on Aug 5 2022, 8:45 AM.

Details

Summary
  • Only call llvm-config --system-libs with the required libraries so libclc doesn't depend on all LLVM components being built.
  • Handle CMAKE_CLC_FLAGS and CMAKE_LLAsm_FLAGS correctly so users can pass custom flags

This contribution is being made by Codeplay on behalf of Samsung.

Diff Detail

Event Timeline

callumfare created this revision.Aug 5 2022, 8:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 5 2022, 8:45 AM
callumfare requested review of this revision.Aug 5 2022, 8:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 5 2022, 8:45 AM
callumfare edited the summary of this revision. (Show Details)Aug 5 2022, 8:56 AM
rjodinchr accepted this revision.Jul 18 2023, 12:32 AM
rjodinchr added a subscriber: rjodinchr.

Everything in this patch has already been merged upstream.
It can be dropped

This revision is now accepted and ready to land.Jul 18 2023, 12:32 AM
kpet closed this revision.Jul 23 2023, 1:55 AM

I can confirm that the flag quoting is present upstream and that the other change does not apply any more. Closing as suggested by @rjodinchr .