Page MenuHomePhabricator

alan-baker (Alan Baker)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 25 2018, 11:27 AM (223 w, 19 h)

Recent Activity

Jan 7 2022

alan-baker added a comment to D116668: libclc: Add clspv64 target.

Sounds reasonable. I agree the high precision fma is already very slow.

Jan 7 2022, 9:55 AM · Restricted Project

Jan 6 2022

alan-baker added a comment to D116668: libclc: Add clspv64 target.

Which version of physical storage buffer do you intend to support? Because if 64-bit integers can be assumes, then the clspv64 target should use the generic implementation of fma instead of the one the standard clspv target uses to avoid all the carry bit logic.

Jan 6 2022, 12:13 PM · Restricted Project

Mar 3 2021

alan-baker added a comment to D94013: [libclc] Add clspv target for libclc.

I pushed https://github.com/alan-baker/llvm-project/commit/248f6480fecb04c343da06aee437d27d75b3a9f6 which converts tabs to spaces in fma.cl if that is helpful.

Mar 3 2021, 10:13 AM · Restricted Project
alan-baker added a comment to D94013: [libclc] Add clspv target for libclc.

My editor clobbers tabs wherever I edit, so fma.cl probably probably has some left over from the original source. I can remove make everything spaces for that file and push an updated commit if you prefer. I think phabricator isn't showing it because it's a new file.

Mar 3 2021, 8:18 AM · Restricted Project

Feb 28 2021

alan-baker added a comment to D94013: [libclc] Add clspv target for libclc.

I've pushed the commit to my fork at 30d41a. I just rebased it on the latest main.

Feb 28 2021, 8:57 PM · Restricted Project

Feb 24 2021

alan-baker added a comment to D94013: [libclc] Add clspv target for libclc.

Thanks for the review! Would it be possible for someone with commit privileges to land this patch?

Feb 24 2021, 12:37 PM · Restricted Project

Feb 23 2021

alan-baker updated the summary of D94013: [libclc] Add clspv target for libclc.
Feb 23 2021, 11:44 AM · Restricted Project
alan-baker added a comment to D81999: libclc: Fix rounding during type conversion.

This definitely looks like the correct fix. I had originally included it in D94013, but it makes more sense as separate commit.

Feb 23 2021, 7:19 AM · Restricted Project
alan-baker added a comment to D94013: [libclc] Add clspv target for libclc.

Is there anything else necessary to complete this review?

Feb 23 2021, 6:59 AM · Restricted Project

Feb 17 2021

alan-baker updated the summary of D94013: [libclc] Add clspv target for libclc.
Feb 17 2021, 8:29 PM · Restricted Project
alan-baker updated the summary of D94013: [libclc] Add clspv target for libclc.
Feb 17 2021, 5:46 AM · Restricted Project

Feb 16 2021

alan-baker added a comment to D94013: [libclc] Add clspv target for libclc.

The FMA does pass conformance. I don't have performance numbers for the 64-bit version vs the uint2 version. It would be worse, but the whole software FMA is already awful performance. The 64-bit version is simpler to understand, so unless you have the same restrictions as I need for clspv, then I wouldn't adopt it.

Hopefully, the different target name will clarify the intent better. This is targeted for use with a cross compiler to Vulkan SPIR-V. The needs are different than the spir targets.

There are existing spirv and spirv64 targets. The new clspv target uses the same spir-- triple as the spirv target, but doesn't use the final spv conversion step and uses O3 optimization. The selection of files is mostly a subset of the existing spirv target.

Feb 16 2021, 9:31 AM · Restricted Project

Feb 11 2021

alan-baker added a comment to D94013: [libclc] Add clspv target for libclc.

It'd be nice to add an explanation why this can't reuse the existing SPIR-V targets and needs to add a new one.
Does the new FMA implementation generate significantly worse code (EG/NI + mesa-spirv should be the only users) than the original? Should it just be replaced? I assume it passes the conformance suite.

Feb 11 2021, 6:02 AM · Restricted Project
alan-baker updated the diff for D94013: [libclc] Add clspv target for libclc.

Fix diff to be based on the correct change.

Feb 11 2021, 5:59 AM · Restricted Project
alan-baker added a comment to D94013: [libclc] Add clspv target for libclc.

I apologize. The last couple patches were based off an older WIP branch. The target is meant to be named differently, hopefully that will clarify,

Feb 11 2021, 5:59 AM · Restricted Project

Feb 10 2021

alan-baker updated the diff for D94013: [libclc] Add clspv target for libclc.

Revert conversions change. Fix whitespace changes. Remove dead code.

Feb 10 2021, 11:21 AM · Restricted Project
alan-baker added inline comments to D94013: [libclc] Add clspv target for libclc.
Feb 10 2021, 11:12 AM · Restricted Project
alan-baker updated the diff for D94013: [libclc] Add clspv target for libclc.

Remove unnecessary whitespace change.

Feb 10 2021, 10:56 AM · Restricted Project
alan-baker added a comment to D94013: [libclc] Add clspv target for libclc.

Is the fma.cl file mostly copied from another file that is already in the tree?

Feb 10 2021, 8:17 AM · Restricted Project

Jan 18 2021

alan-baker added a comment to D94013: [libclc] Add clspv target for libclc.

Anyone able to review this patch?

Jan 18 2021, 11:23 AM · Restricted Project

Jan 4 2021

alan-baker requested review of D94013: [libclc] Add clspv target for libclc.
Jan 4 2021, 8:32 AM · Restricted Project

Jan 3 2020

alan-baker added a comment to D72109: [cmake] Use relative cmake binary dir for processing pass plugins.

I do not have commit access. Would it be possible for someone to commit it on my behalf? Thanks.

Jan 3 2020, 6:28 AM · Restricted Project
alan-baker updated the diff for D72109: [cmake] Use relative cmake binary dir for processing pass plugins.

Switch to use LLVM_BINARY_DIR instead of CMAKE_CURRENT_BINARY_DIR.

Jan 3 2020, 5:38 AM · Restricted Project
alan-baker added inline comments to D72109: [cmake] Use relative cmake binary dir for processing pass plugins.
Jan 3 2020, 5:38 AM · Restricted Project

Jan 2 2020

alan-baker created D72109: [cmake] Use relative cmake binary dir for processing pass plugins.
Jan 2 2020, 2:00 PM · Restricted Project
alan-baker added a reviewer for D72109: [cmake] Use relative cmake binary dir for processing pass plugins: Meinersbur.
Jan 2 2020, 2:00 PM · Restricted Project

Jun 26 2019

alan-baker added a comment to D63097: [cmake] Don't add Support/Testing library if tests are not included.

Friendly ping in case this fell off the radar.

Jun 26 2019, 6:07 AM · Restricted Project

Jun 17 2019

alan-baker updated the diff for D63097: [cmake] Don't add Support/Testing library if tests are not included.

Changed to use the top level LLVM build option.

Jun 17 2019, 11:48 AM · Restricted Project

Jun 10 2019

alan-baker created D63097: [cmake] Don't add Support/Testing library if tests are not included.
Jun 10 2019, 2:09 PM · Restricted Project

Jun 27 2018

alan-baker added a comment to D48556: Fix asserts in AMDGCN fmed3 folding by handling more cases of NaN.

I don't have commit access to LLVM, could you please land this patch on my behalf?

Jun 27 2018, 7:39 AM

Jun 26 2018

alan-baker updated the diff for D48556: Fix asserts in AMDGCN fmed3 folding by handling more cases of NaN.

Refactor NaN checks to reduce duplication. Reword comment.

Jun 26 2018, 6:17 AM

Jun 25 2018

alan-baker updated the diff for D48556: Fix asserts in AMDGCN fmed3 folding by handling more cases of NaN.

Adding extra tests.

Jun 25 2018, 1:57 PM
alan-baker added inline comments to D48556: Fix asserts in AMDGCN fmed3 folding by handling more cases of NaN.
Jun 25 2018, 1:49 PM
alan-baker added inline comments to D48556: Fix asserts in AMDGCN fmed3 folding by handling more cases of NaN.
Jun 25 2018, 1:36 PM
alan-baker created D48556: Fix asserts in AMDGCN fmed3 folding by handling more cases of NaN.
Jun 25 2018, 12:04 PM