This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Remove unused MIMG tablegen variants
ClosedPublic

Authored by mbrkusanin on Aug 5 2022, 4:12 AM.

Details

Summary

There are no AMDGPUSampleVariant versions for _G16, it is treated more like a
modifier for derivatives (_D) (also for intrinsics where it is overloaded type
instead of part of intrinsics name) so we ended up making more variants for
these instruction then we actually needed.

32-bit derivatives need 6 dwords at most, while 16-bit need 4 at most. Using
same AMDGPUSampleVariant for both, we ended up creating 2 extra variants per
instruction than were necessary.

In total this deletes 260 unused tablegen records.

Diff Detail

Event Timeline

mbrkusanin created this revision.Aug 5 2022, 4:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 5 2022, 4:12 AM
mbrkusanin requested review of this revision.Aug 5 2022, 4:12 AM
arsenm accepted this revision.Aug 5 2022, 6:06 AM
This revision is now accepted and ready to land.Aug 5 2022, 6:06 AM
This revision was landed with ongoing or failed builds.Aug 5 2022, 6:55 AM
This revision was automatically updated to reflect the committed changes.