This is an archive of the discontinued LLVM Phabricator instance.

[ORC] Actually propagate memory unmapping errors on Windows
ClosedPublic

Authored by mstorsjo on Aug 3 2022, 1:09 AM.

Details

Summary

This fixes warnings like these:

../lib/ExecutionEngine/Orc/MemoryMapper.cpp:364:9: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result]
        joinErrors(std::move(Err),
        ^~~~~~~~~~ ~~~~~~~~~~~~~~~

Diff Detail

Event Timeline

mstorsjo created this revision.Aug 3 2022, 1:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 3 2022, 1:09 AM
mstorsjo requested review of this revision.Aug 3 2022, 1:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 3 2022, 1:09 AM
argentite accepted this revision.Aug 3 2022, 10:09 AM

That was a mistake, Thanks.

This revision is now accepted and ready to land.Aug 3 2022, 10:09 AM
This revision was landed with ongoing or failed builds.Aug 4 2022, 1:15 AM
This revision was automatically updated to reflect the committed changes.