Page MenuHomePhabricator
Differential D130865

[libc++][ranges] Implement `ranges::sample`.
ClosedPublic
Actions

Authored by var-const on Sun, Jul 31, 9:32 PM.

Details

Reviewers
philnik
huixie90
ldionne
Group Reviewers
Restricted Project
Commits
rG6bdb64223473: [libc++][ranges] Implement `ranges::sample`.
Summary

This is the last range algorithm from C++20.

Diff Detail

Event Timeline

var-const created this revision.Sun, Jul 31, 9:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptSun, Jul 31, 9:32 PM
Herald added subscribers: wenlei, mgorny. · View Herald Transcript
var-const requested review of this revision.Sun, Jul 31, 9:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptSun, Jul 31, 9:32 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
var-const updated this revision to Diff 448912.Sun, Jul 31, 9:32 PM

Use the actual patch number.

var-const added reviewers: philnik, huixie90, ldionne.Sun, Jul 31, 9:33 PM
var-const updated this revision to Diff 448914.Sun, Jul 31, 9:40 PM

Fix the CI, fix forgotten issue.

var-const updated this revision to Diff 448915.Sun, Jul 31, 9:44 PM

Fix the CI.

Harbormaster completed remote builds in B178498: Diff 448915.Sun, Jul 31, 10:21 PM
var-const updated this revision to Diff 448938.Mon, Aug 1, 12:53 AM

Fix the CI.

Harbormaster completed remote builds in B178514: Diff 448938.Mon, Aug 1, 3:05 AM
var-const updated this revision to Diff 449178.Mon, Aug 1, 8:34 PM

Fix the CI (nasty macros).

Harbormaster completed remote builds in B178682: Diff 449178.Mon, Aug 1, 10:57 PM
ldionne accepted this revision.Tue, Aug 2, 2:50 PM
This revision is now accepted and ready to land.Tue, Aug 2, 2:50 PM
Closed by commit rG6bdb64223473: [libc++][ranges] Implement `ranges::sample`. (authored by var-const). · Explain WhyTue, Aug 2, 10:35 PM
This revision was automatically updated to reflect the committed changes.
var-const added a commit: rG6bdb64223473: [libc++][ranges] Implement `ranges::sample`..

Revision Contents
Changeset List

PathSize
libcxx/
docs/
Status/
2 lines
include/
2 lines
__algorithm/
14 lines
74 lines
34 lines
48 lines
62 lines
13 lines
4 lines
test/
libcxx/
2 lines
std/
algorithms/
alg.modifying.operations/
alg.random.sample/
334 lines
4 lines
6 lines
library/
description/
conventions/
customization.point.object/
2 lines

Diff 449543

View Options

libcxx/docs/Status/RangesAlgorithms.csv

Loading...
View Options

libcxx/include/CMakeLists.txt

Loading...
View Options

libcxx/include/__algorithm/iterator_operations.h

Loading...
View Options

libcxx/include/__algorithm/ranges_sample.h

Loading...
View Options

libcxx/include/__algorithm/ranges_shuffle.h

Loading...
View Options

libcxx/include/__algorithm/sample.h

Loading...
View Options

libcxx/include/__algorithm/uniform_random_bit_generator_adaptor.h

Loading...
View Options

libcxx/include/algorithm

Loading...
View Options

libcxx/include/module.modulemap.in

Loading...
View Options

libcxx/test/libcxx/private_headers.verify.cpp

Loading...
View Options

libcxx/test/std/algorithms/alg.modifying.operations/alg.random.sample/ranges_sample.pass.cpp

Loading...
View Options

libcxx/test/std/algorithms/ranges_robust_against_omitting_invoke.pass.cpp

Loading...
View Options

libcxx/test/std/algorithms/ranges_robust_against_proxy_iterators.pass.cpp

Loading...
View Options

libcxx/test/std/library/description/conventions/customization.point.object/niebloid.compile.pass.cpp

Loading...