This is an archive of the discontinued LLVM Phabricator instance.

[GIsel] Add missing space between type and name in GICombinerHelperArg
ClosedPublic

Authored by Kai on Jul 30 2022, 9:29 AM.

Details

Summary

When using AdditionalArguments in a GICombinerHelper, the generator does not put a space between the type and the name.

E.g.

let AdditionalArguments = [GICombinerHelperArg<"bool", "IsSomething">];

ends up as

boolIsSomething) const;

in the generated file. This change adds a space between the type and the name.

Diff Detail

Event Timeline

Kai created this revision.Jul 30 2022, 9:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 30 2022, 9:29 AM
Kai requested review of this revision.Jul 30 2022, 9:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 30 2022, 9:29 AM
aemerson accepted this revision.Aug 2 2022, 2:43 AM

LGTM.

This revision is now accepted and ready to land.Aug 2 2022, 2:43 AM
This revision was landed with ongoing or failed builds.Aug 2 2022, 10:36 AM
This revision was automatically updated to reflect the committed changes.