This is an archive of the discontinued LLVM Phabricator instance.

Differential D130546

[BOLT][TEST] Update fptr.test
ClosedPublic

Authored by Amir on Jul 25 2022, 9:36 PM.

Details

Reviewers
rafauler
maksfb
Commits
rG79c2fe066d8a: [BOLT][TEST] Update fptr.test
Summary

The test exercises an implicit ptr-to-int conversion which is made an error in
D129881. We acknowledge the error but still want to test this case.
Add -Wno-int-conversion to silence the error.

Diff Detail

Event Timeline

Amir created this revision.Jul 25 2022, 9:36 PM
Herald added a reviewer: rafauler. · View Herald TranscriptJul 25 2022, 9:36 PM
Herald added a reviewer: maksfb. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: ayermolo. · View Herald Transcript
Amir requested review of this revision.Jul 25 2022, 9:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 25 2022, 9:36 PM
Herald added subscribers: llvm-commits, yota9. · View Herald Transcript
maksfb accepted this revision.Jul 25 2022, 9:51 PM
This revision is now accepted and ready to land.Jul 25 2022, 9:51 PM
Harbormaster completed remote builds in B177531: Diff 447557.Jul 25 2022, 9:51 PM
Closed by commit rG79c2fe066d8a: [BOLT][TEST] Update fptr.test (authored by Amir). · Explain WhyJul 25 2022, 10:01 PM
This revision was automatically updated to reflect the committed changes.
Amir added a commit: rG79c2fe066d8a: [BOLT][TEST] Update fptr.test.

Revision Contents

PathSize
bolt/
test/
runtime/
2 lines

Diff 447562

bolt/test/runtime/fptr.test

# Make sure BOLT correctly updates values based on function pointer. # Make sure BOLT correctly updates values based on function pointer.
RUN: %clang %cflags -no-pie %p/Inputs/fptr.c -Wl,-q -o %t.exe RUN: %clang %cflags -Wno-int-conversion -no-pie %p/Inputs/fptr.c -Wl,-q -o %t.exe
RUN: llvm-bolt %t.exe -o %t --lite=0 RUN: llvm-bolt %t.exe -o %t --lite=0
RUN: %t | FileCheck %s RUN: %t | FileCheck %s
CHECK: Global = 0x[[#%x,ADDR:]] CHECK: Global = 0x[[#%x,ADDR:]]
CHECK-NEXT: Local = 0x[[#ADDR]] CHECK-NEXT: Local = 0x[[#ADDR]]
CHECK-NEXT: Local2 = 0x[[#ADDR]] CHECK-NEXT: Local2 = 0x[[#ADDR]]