This is an archive of the discontinued LLVM Phabricator instance.

[BOLT] Support files with no symbols
ClosedPublic

Authored by Amir on Jul 25 2022, 9:25 PM.

Details

Summary

LastSymbol handling in discoverFileObjects assumes a non-zero number of
symbols in an object file. It's not the case for broken_dynsym.test added in
D130073, and potentially other stripped binaries.

Diff Detail

Event Timeline

Amir created this revision.Jul 25 2022, 9:25 PM
Herald added a reviewer: maksfb. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: ayermolo. · View Herald Transcript
Amir requested review of this revision.Jul 25 2022, 9:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 25 2022, 9:26 PM
maksfb accepted this revision.Jul 25 2022, 10:01 PM
This revision is now accepted and ready to land.Jul 25 2022, 10:01 PM
This revision was automatically updated to reflect the committed changes.