This is an archive of the discontinued LLVM Phabricator instance.

Differential D130468

[lldb][ARM] Add tests for vpush/vpop D registers
ClosedPublic

Authored by DavidSpickett on Jul 25 2022, 2:14 AM.

Details

Reviewers
clayborg
Commits
rG10c2bab50e7a: [lldb][ARM] Add tests for vpush/vpop D registers
Summary

Previously we just checked via S regs and were not checking
memory content after pushes.

The vpush test confirms that the fix in https://reviews.llvm.org/D130307
is working.

Memory will only be checked if an "after" state is provided.

Diff Detail

Event Timeline

DavidSpickett created this revision.Jul 25 2022, 2:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 25 2022, 2:14 AM
Herald added a subscriber: kristof.beyls. · View Herald Transcript
DavidSpickett requested review of this revision.Jul 25 2022, 2:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 25 2022, 2:14 AM
Herald added a subscriber: lldb-commits. · View Herald Transcript
Harbormaster completed remote builds in B177314: Diff 447245.Jul 25 2022, 2:15 AM
Herald added a subscriber: JDevlieghere. · View Herald TranscriptJul 25 2022, 2:15 AM
DavidSpickett added a reviewer: clayborg.Jul 25 2022, 2:18 AM
DavidSpickett added inline comments.
lldb/test/API/arm/emulation/new-test-files/test-vpush-1-dregs-thumb.dat
70

This is the part that fails without the fix from https://reviews.llvm.org/D130307. Every other word will be zero.

DavidSpickett added a parent revision: D130467: [lldb][ARM] Misc improvements to TestEmulations.Jul 25 2022, 2:18 AM
clayborg accepted this revision.Jul 25 2022, 5:03 PM
This revision is now accepted and ready to land.Jul 25 2022, 5:03 PM
This revision was landed with ongoing or failed builds.Jul 26 2022, 1:41 AM
Closed by commit rG10c2bab50e7a: [lldb][ARM] Add tests for vpush/vpop D registers (authored by DavidSpickett). · Explain Why
This revision was automatically updated to reflect the committed changes.
DavidSpickett added a commit: rG10c2bab50e7a: [lldb][ARM] Add tests for vpush/vpop D registers.

Revision Contents

PathSize
lldb/
source/
Plugins/
Instruction/
ARM/
12 lines
test/
API/
arm/
emulation/
new-test-files/
125 lines
125 lines

Diff 447245

lldb/source/Plugins/Instruction/ARM/EmulationStateARM.cpp

//===-- EmulationStateARM.cpp ---------------------------------------------===// //===-- EmulationStateARM.cpp ---------------------------------------------===//
Lint: Lint
Inline Actions

clang-format not found in user’s local PATH; not linting file.

Lint: Lint: clang-format not found in user’s local PATH; not linting file.
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
▲ Show 20 Lines • Show All 265 Lines • ▼ Show 20 Linesbool EmulationStateARM::CompareState(EmulationStateARM &other_state,
for (int i = 0; match && i < 16; ++i) { for (int i = 0; match && i < 16; ++i) {
if (m_vfp_regs.d_regs[i] != other_state.m_vfp_regs.d_regs[i]) { if (m_vfp_regs.d_regs[i] != other_state.m_vfp_regs.d_regs[i]) {
match = false; match = false;
out_stream->Printf("d%d: 0x%lx != 0x%lx\n", i + 16, m_vfp_regs.d_regs[i], out_stream->Printf("d%d: 0x%lx != 0x%lx\n", i + 16, m_vfp_regs.d_regs[i],
other_state.m_vfp_regs.d_regs[i]); other_state.m_vfp_regs.d_regs[i]);
} }
} }
// other_state is the expected state. If it has memory, check it.
if (!other_state.m_memory.empty() && m_memory != other_state.m_memory) {
match = false;
out_stream->Printf("memory does not match\n");
out_stream->Printf("got memory:\n");
for (auto p : m_memory)
out_stream->Printf("0x%08lx: 0x%08x\n", p.first, p.second);
out_stream->Printf("expected memory:\n");
for (auto p : other_state.m_memory)
out_stream->Printf("0x%08lx: 0x%08x\n", p.first, p.second);
}
return match; return match;
} }
bool EmulationStateARM::LoadRegistersStateFromDictionary( bool EmulationStateARM::LoadRegistersStateFromDictionary(
OptionValueDictionary *reg_dict, char kind, int first_reg, int num) { OptionValueDictionary *reg_dict, char kind, int first_reg, int num) {
StreamString sstr; StreamString sstr;
for (int i = 0; i < num; ++i) { for (int i = 0; i < num; ++i) {
sstr.Clear(); sstr.Clear();
▲ Show 20 Lines • Show All 81 Lines • Show Last 20 Lines

lldb/test/API/arm/emulation/new-test-files/test-vpop-1-dregs-thumb.dat

  • This file was added.
InstructionEmulationState={
assembly_string="vpop {d11, d12, d13, d14}"
triple=thumb-apple-ios
opcode=0xecbdbb08
before_state={
memory={
address=0x2fdffe60
data_encoding=uint32_t
data=[
0x22222222
0x11111111
0x44444444
0x33333333
0x66666666
0x55555555
0x88888888
0x77777777
]
}
registers={
r0=0x00000000
r1=0x00000001
r2=0x00000002
r3=0x00000003
r4=0x00000004
r5=0x00000005
r6=0x00000006
r7=0x2fdffe60
r8=0x00000008
r9=0x00000009
r10=0x0000000a
r11=0x0000000b
r12=0x0000000c
r13=0x2fdffe60
r14=0x00002f80
r15=0x00002ff8
cpsr=0x60000030
d0=0x0
d1=0x0
d2=0x0
d3=0x0
d4=0x0
d5=0x0
d6=0x0
d7=0x0
d8=0x0
d9=0x0
d10=0x0
d11=0x0
d12=0x0
d13=0x0
d14=0x0
d15=0x0
d16=0x0
d17=0x0
d18=0x0
d19=0x0
d20=0x0
d21=0x0
d22=0x0
d23=0x0
d24=0x0
d25=0x0
d26=0x0
d27=0x0
d28=0x0
d29=0x0
d30=0x0
d31=0x0
}
}
after_state={
registers={
r0=0x00000000
r1=0x00000001
r2=0x00000002
r3=0x00000003
r4=0x00000004
r5=0x00000005
r6=0x00000006
r7=0x2fdffe60
r8=0x00000008
r9=0x00000009
r10=0x0000000a
r11=0x0000000b
r12=0x0000000c
r13=0x2fdffe80
r14=0x00002f80
r15=0x00002ffc
cpsr=0x60000030
d0=0x0000000000000000
d1=0x0000000000000000
d2=0x0000000000000000
d3=0x0000000000000000
d4=0x0000000000000000
d5=0x0000000000000000
d6=0x0000000000000000
d7=0x0000000000000000
d8=0x0000000000000000
d9=0x0000000000000000
d10=0x0000000000000000
d11=0x1111111122222222
d12=0x3333333344444444
d13=0x5555555566666666
d14=0x7777777788888888
d15=0x0000000000000000
d16=0x0000000000000000
d17=0x0000000000000000
d18=0x0000000000000000
d19=0x0000000000000000
d20=0x0000000000000000
d21=0x0000000000000000
d22=0x0000000000000000
d23=0x0000000000000000
d24=0x0000000000000000
d25=0x0000000000000000
d26=0x0000000000000000
d27=0x0000000000000000
d28=0x0000000000000000
d29=0x0000000000000000
d30=0x0000000000000000
d31=0x0000000000000000
}
}
}

lldb/test/API/arm/emulation/new-test-files/test-vpush-1-dregs-thumb.dat

  • This file was added.
InstructionEmulationState={
assembly_string="vpush {d11, d12, d13, d14}"
triple=thumb-apple-ios
opcode=0xed2dbb08
before_state={
registers={
r0=0x00000000
r1=0x00000001
r2=0x00000002
r3=0x00000003
r4=0x00000004
r5=0x00000005
r6=0x00000006
r7=0x2fdffe60
r8=0x00000008
r9=0x00000009
r10=0x0000000a
r11=0x0000000b
r12=0x0000000c
r13=0x2fdffe80
r14=0x00002f80
r15=0x00002ff8
cpsr=0x60000030
d0=0x0000000000000000
d1=0x0000000000000000
d2=0x0000000000000000
d3=0x0000000000000000
d4=0x0000000000000000
d5=0x0000000000000000
d6=0x0000000000000000
d7=0x0000000000000000
d8=0x0000000000000000
d9=0x0000000000000000
d10=0x0000000000000000
d11=0x1111111122222222
d12=0x3333333344444444
d13=0x5555555566666666
d14=0x7777777788888888
d15=0x0000000000000000
d16=0x0000000000000000
d17=0x0000000000000000
d18=0x0000000000000000
d19=0x0000000000000000
d20=0x0000000000000000
d21=0x0000000000000000
d22=0x0000000000000000
d23=0x0000000000000000
d24=0x0000000000000000
d25=0x0000000000000000
d26=0x0000000000000000
d27=0x0000000000000000
d28=0x0000000000000000
d29=0x0000000000000000
d30=0x0000000000000000
d31=0x0000000000000000
}
}
after_state={
memory={
address=0x2fdffe60
data_encoding=uint32_t
data=[
0x22222222
0x11111111
0x44444444
0x33333333
0x66666666
0x55555555
0x88888888
0x77777777
DavidSpickettAuthorUnsubmitted
Done
ReplyInline Actions

This is the part that fails without the fix from https://reviews.llvm.org/D130307. Every other word will be zero.

DavidSpickett: This is the part that fails without the fix from https://reviews.llvm.org/D130307. Every other…
]
}
registers={
r0=0x00000000
r1=0x00000001
r2=0x00000002
r3=0x00000003
r4=0x00000004
r5=0x00000005
r6=0x00000006
r7=0x2fdffe60
r8=0x00000008
r9=0x00000009
r10=0x0000000a
r11=0x0000000b
r12=0x0000000c
r13=0x2fdffe60
r14=0x00002f80
r15=0x00002ffc
cpsr=0x60000030
d0=0x0000000000000000
d1=0x0000000000000000
d2=0x0000000000000000
d3=0x0000000000000000
d4=0x0000000000000000
d5=0x0000000000000000
d6=0x0000000000000000
d7=0x0000000000000000
d8=0x0000000000000000
d9=0x0000000000000000
d10=0x0000000000000000
d11=0x1111111122222222
d12=0x3333333344444444
d13=0x5555555566666666
d14=0x7777777788888888
d15=0x0000000000000000
d16=0x0000000000000000
d17=0x0000000000000000
d18=0x0000000000000000
d19=0x0000000000000000
d20=0x0000000000000000
d21=0x0000000000000000
d22=0x0000000000000000
d23=0x0000000000000000
d24=0x0000000000000000
d25=0x0000000000000000
d26=0x0000000000000000
d27=0x0000000000000000
d28=0x0000000000000000
d29=0x0000000000000000
d30=0x0000000000000000
d31=0x0000000000000000
}
}
}