This is an archive of the discontinued LLVM Phabricator instance.

[lldb][ARM] Add tests for vpush/vpop D registers
ClosedPublic

Authored by DavidSpickett on Jul 25 2022, 2:14 AM.

Details

Summary

Previously we just checked via S regs and were not checking
memory content after pushes.

The vpush test confirms that the fix in https://reviews.llvm.org/D130307
is working.

Memory will only be checked if an "after" state is provided.

Diff Detail

Event Timeline

DavidSpickett created this revision.Jul 25 2022, 2:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 25 2022, 2:14 AM
DavidSpickett requested review of this revision.Jul 25 2022, 2:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 25 2022, 2:14 AM
DavidSpickett added inline comments.
lldb/test/API/arm/emulation/new-test-files/test-vpush-1-dregs-thumb.dat
70

This is the part that fails without the fix from https://reviews.llvm.org/D130307. Every other word will be zero.

clayborg accepted this revision.Jul 25 2022, 5:03 PM
This revision is now accepted and ready to land.Jul 25 2022, 5:03 PM
This revision was landed with ongoing or failed builds.Jul 26 2022, 1:41 AM
This revision was automatically updated to reflect the committed changes.