Previously we just checked via S regs and were not checking
memory content after pushes.
The vpush test confirms that the fix in https://reviews.llvm.org/D130307
is working.
Memory will only be checked if an "after" state is provided.
Paths
| Differential D130468
[lldb][ARM] Add tests for vpush/vpop D registers ClosedPublic Authored by DavidSpickett on Jul 25 2022, 2:14 AM.
Details
Summary Previously we just checked via S regs and were not checking The vpush test confirms that the fix in https://reviews.llvm.org/D130307 Memory will only be checked if an "after" state is provided.
Diff Detail
Event TimelineDavidSpickett added inline comments.
DavidSpickett added a parent revision: D130467: [lldb][ARM] Misc improvements to TestEmulations.Jul 25 2022, 2:18 AM This revision is now accepted and ready to land.Jul 25 2022, 5:03 PM This revision was landed with ongoing or failed builds.Jul 26 2022, 1:41 AM Closed by commit rG10c2bab50e7a: [lldb][ARM] Add tests for vpush/vpop D registers (authored by DavidSpickett). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 447624 lldb/source/Plugins/Instruction/ARM/EmulationStateARM.cpp
lldb/test/API/arm/emulation/new-test-files/test-vpop-1-dregs-thumb.dat
lldb/test/API/arm/emulation/new-test-files/test-vpush-1-dregs-thumb.dat
|
This is the part that fails without the fix from https://reviews.llvm.org/D130307. Every other word will be zero.