This is an archive of the discontinued LLVM Phabricator instance.

Differential D130435

[test-suite] Add -Wno-int-conversion to siod
ClosedPublic

Authored by Jake-Egan on Jul 23 2022, 9:01 PM.

Details

Reviewers
aaron.ballman
MaskRay
Commits
rTf47d83408790: Fix a -Wint-conversion failure with an AIX test bot
Summary

siod/slibu.c fails to build on AIX due to -Wint-conversion being upgraded to an error by D129881. So this patch adds -Wno-int-conversion to suppress the error.

Diff Detail

Event Timeline

Jake-Egan created this revision.Jul 23 2022, 9:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 23 2022, 9:01 PM
Herald added a subscriber: mgorny. · View Herald Transcript
Jake-Egan requested review of this revision.Jul 23 2022, 9:01 PM
Harbormaster completed remote builds in B177208: Diff 447106.Jul 23 2022, 9:01 PM
Jake-Egan edited the summary of this revision. (Show Details)Jul 23 2022, 9:04 PM
Jake-Egan added reviewers: aaron.ballman, MaskRay.
Herald added a subscriber: StephenFan. · View Herald TranscriptJul 23 2022, 9:04 PM
MaskRay accepted this revision.Jul 24 2022, 1:27 AM

LGTM.

This revision is now accepted and ready to land.Jul 24 2022, 1:27 AM
Closed by commit rTf47d83408790: Fix a -Wint-conversion failure with an AIX test bot (authored by aaron.ballman). · Explain WhyJul 24 2022, 6:24 AM
This revision was automatically updated to reflect the committed changes.
aaron.ballman added a commit: rTf47d83408790: Fix a -Wint-conversion failure with an AIX test bot.
aaron.ballman added a comment.Jul 24 2022, 6:27 AM

Oops, I'm sorry, I fixed the breakage before I noticed this review! I've already landed the same fix in f47d83408790e3558e5fdb871ba66996b1b1183d, but thank you for this just the same! FWIW, next time you should feel free to land this sort of fix on your own, if you want to (it's always fine to land fixes without precommit review).

Jake-Egan added a comment.Jul 24 2022, 6:30 AM

I'll do that next time, thank you!

Revision Contents

PathSize
MultiSource/
Applications/
siod/
2 lines
2 lines

Diff 447106

MultiSource/Applications/siod/CMakeLists.txt

list(APPEND CPPFLAGS -D__USE_MISC -D__USE_GNU -D__USE_SVID -D__USE_XOPEN_EXTENDED -D__USE_XOPEN -Dunix) list(APPEND CPPFLAGS -D__USE_MISC -D__USE_GNU -D__USE_SVID -D__USE_XOPEN_EXTENDED -D__USE_XOPEN -Dunix)
list(APPEND CFLAGS -Wno-implicit-function-declaration -Wno-implicit-int) list(APPEND CFLAGS -Wno-implicit-function-declaration -Wno-implicit-int -Wno-int-conversion)
list(APPEND LDFLAGS -lm) list(APPEND LDFLAGS -lm)
set(RUN_OPTIONS -v1 test.scm) set(RUN_OPTIONS -v1 test.scm)
llvm_multisource(siod) llvm_multisource(siod)
llvm_test_data(siod test.scm) llvm_test_data(siod test.scm)

MultiSource/Applications/siod/Makefile

LEVEL = ../../.. LEVEL = ../../..
PROG = siod PROG = siod
CPPFLAGS = -D__USE_MISC -D__USE_GNU -D__USE_SVID -D__USE_XOPEN_EXTENDED -D__USE_XOPEN -Dunix CPPFLAGS = -D__USE_MISC -D__USE_GNU -D__USE_SVID -D__USE_XOPEN_EXTENDED -D__USE_XOPEN -Dunix
CFLAGS += -Wno-implicit-function-declaration -Wno-implicit-int CFLAGS += -Wno-implicit-function-declaration -Wno-implicit-int -Wno-int-conversion
LDFLAGS = -lm $(TOOLLINKOPTS) LDFLAGS = -lm $(TOOLLINKOPTS)
RUN_OPTIONS = -v1 $(PROJ_SRC_DIR)/test.scm RUN_OPTIONS = -v1 $(PROJ_SRC_DIR)/test.scm
# Define USE_REFERENCE_OUTPUT which is a signal to Makefile.programs that the # Define USE_REFERENCE_OUTPUT which is a signal to Makefile.programs that the
# natively compiled program should not be run but that its output should be # natively compiled program should not be run but that its output should be
# "faked" by copying the reference output. This is because gcc-4.6 miscompiles # "faked" by copying the reference output. This is because gcc-4.6 miscompiles
# siod, resulting in a program that fails to parse the Fibonacci test. # siod, resulting in a program that fails to parse the Fibonacci test.
USE_REFERENCE_OUTPUT := 1 USE_REFERENCE_OUTPUT := 1
include ../../Makefile.multisrc include ../../Makefile.multisrc