This is an archive of the discontinued LLVM Phabricator instance.

Differential D130143

[mlir] Fix macOS tests
ClosedPublic

Authored by powderluv on Jul 19 2022, 9:13 PM.

Details

Reviewers
stellaraccident
Commits
rGf9676d2d2219: [mlir] Fix macOS tests
Summary

Fix shared library names on macOS for execution_engine.py test.

Diff Detail

Event Timeline

powderluv created this revision.Jul 19 2022, 9:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 19 2022, 9:13 PM
Herald added subscribers: bzcheeseman, sdasgup3, wenzhicui and 18 others. · View Herald Transcript
powderluv requested review of this revision.Jul 19 2022, 9:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 19 2022, 9:13 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
stellaraccident accepted this revision.Jul 19 2022, 9:18 PM

Do you have commit access?

This revision is now accepted and ready to land.Jul 19 2022, 9:18 PM
powderluv added a comment.Jul 19 2022, 9:23 PM

Don't have commit access yet.

Harbormaster completed remote builds in B176418: Diff 446035.Jul 19 2022, 10:12 PM
Closed by commit rGf9676d2d2219: [mlir] Fix macOS tests (authored by powderluv, committed by ftynse). · Explain WhyJul 20 2022, 1:19 AM
This revision was automatically updated to reflect the committed changes.
ftynse added a commit: rGf9676d2d2219: [mlir] Fix macOS tests.

Revision Contents

PathSize
mlir/
test/
python/
5 lines

Diff 446035

mlir/test/python/execution_engine.py

Show First 20 Lines • Show All 484 Lines • ▼ Show 20 Lines with Context():
arg0_memref_ptr = ctypes.pointer( arg0_memref_ptr = ctypes.pointer(
ctypes.pointer(get_ranked_memref_descriptor(arg0))) ctypes.pointer(get_ranked_memref_descriptor(arg0)))
if sys.platform == 'win32': if sys.platform == 'win32':
shared_libs = [ shared_libs = [
"../../../../bin/mlir_runner_utils.dll", "../../../../bin/mlir_runner_utils.dll",
"../../../../bin/mlir_c_runner_utils.dll" "../../../../bin/mlir_c_runner_utils.dll"
] ]
elif sys.platform == 'darwin':
shared_libs = [
"../../../../lib/libmlir_runner_utils.dylib",
"../../../../lib/libmlir_c_runner_utils.dylib"
]
else: else:
shared_libs = [ shared_libs = [
"../../../../lib/libmlir_runner_utils.so", "../../../../lib/libmlir_runner_utils.so",
"../../../../lib/libmlir_c_runner_utils.so" "../../../../lib/libmlir_c_runner_utils.so"
] ]
execution_engine = ExecutionEngine( execution_engine = ExecutionEngine(
lowerToLLVM(module), lowerToLLVM(module),
▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines