This is an archive of the discontinued LLVM Phabricator instance.

Differential D129978

[libcxx] Fix copy and pasto that broke the build on Android/Fuchsia
ClosedPublic

Authored by brad on Jul 17 2022, 7:31 PM.

Details

Reviewers
Mordante
phosek
ldionne
Group Reviewers
Restricted Project
Commits
rGda11b775b17c: [libcxx] Fix copy and pasto that broke the build on Android/Fuchsia

Diff Detail

Event Timeline

brad created this revision.Jul 17 2022, 7:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 17 2022, 7:31 PM
Herald added subscribers: abrachet, danielkiss. · View Herald Transcript
brad requested review of this revision.Jul 17 2022, 7:31 PM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptJul 17 2022, 7:31 PM
phosek accepted this revision.Jul 17 2022, 9:10 PM

LGTM thank you!

Harbormaster completed remote builds in B175938: Diff 445373.Jul 17 2022, 10:37 PM
Mordante accepted this revision.Jul 17 2022, 10:56 PM

LGTM, thanks for the fix.

This revision is now accepted and ready to land.Jul 17 2022, 10:56 PM
Closed by commit rGda11b775b17c: [libcxx] Fix copy and pasto that broke the build on Android/Fuchsia (authored by brad). · Explain WhyJul 18 2022, 6:17 AM
This revision was automatically updated to reflect the committed changes.
brad added a commit: rGda11b775b17c: [libcxx] Fix copy and pasto that broke the build on Android/Fuchsia.
Mordante mentioned this in D129922: [libcxx] Replace remaining _LIBCPP_INLINE_VISIBILITY in __support.Jul 18 2022, 9:07 AM

Revision Contents

PathSize
libcxx/
include/
__support/
xlocale/
16 lines

Diff 445475

libcxx/include/__support/xlocale/__strtonum_fallback.h

Show All 13 Lines
#ifndef _LIBCPP_SUPPORT_XLOCALE_STRTONUM_FALLBACK_H #ifndef _LIBCPP_SUPPORT_XLOCALE_STRTONUM_FALLBACK_H
#define _LIBCPP_SUPPORT_XLOCALE_STRTONUM_FALLBACK_H #define _LIBCPP_SUPPORT_XLOCALE_STRTONUM_FALLBACK_H
#ifdef __cplusplus #ifdef __cplusplus
extern "C" { extern "C" {
#endif #endif
inline _LIBCPP_HIDE_FROM_ABI int float inline _LIBCPP_HIDE_FROM_ABI float
strtof_l(const char *__nptr, char **__endptr, locale_t) { strtof_l(const char *__nptr, char **__endptr, locale_t) {
return ::strtof(__nptr, __endptr); return ::strtof(__nptr, __endptr);
} }
inline _LIBCPP_HIDE_FROM_ABI int double inline _LIBCPP_HIDE_FROM_ABI double
strtod_l(const char *__nptr, char **__endptr, locale_t) { strtod_l(const char *__nptr, char **__endptr, locale_t) {
return ::strtod(__nptr, __endptr); return ::strtod(__nptr, __endptr);
} }
inline _LIBCPP_HIDE_FROM_ABI int long double inline _LIBCPP_HIDE_FROM_ABI long double
strtold_l(const char *__nptr, char **__endptr, locale_t) { strtold_l(const char *__nptr, char **__endptr, locale_t) {
return ::strtold(__nptr, __endptr); return ::strtold(__nptr, __endptr);
} }
inline _LIBCPP_HIDE_FROM_ABI int long long inline _LIBCPP_HIDE_FROM_ABI long long
strtoll_l(const char *__nptr, char **__endptr, int __base, locale_t) { strtoll_l(const char *__nptr, char **__endptr, int __base, locale_t) {
return ::strtoll(__nptr, __endptr, __base); return ::strtoll(__nptr, __endptr, __base);
} }
inline _LIBCPP_HIDE_FROM_ABI int unsigned long long inline _LIBCPP_HIDE_FROM_ABI unsigned long long
strtoull_l(const char *__nptr, char **__endptr, int __base, locale_t) { strtoull_l(const char *__nptr, char **__endptr, int __base, locale_t) {
return ::strtoull(__nptr, __endptr, __base); return ::strtoull(__nptr, __endptr, __base);
} }
inline _LIBCPP_HIDE_FROM_ABI int long long inline _LIBCPP_HIDE_FROM_ABI long long
wcstoll_l(const wchar_t *__nptr, wchar_t **__endptr, int __base, locale_t) { wcstoll_l(const wchar_t *__nptr, wchar_t **__endptr, int __base, locale_t) {
return ::wcstoll(__nptr, __endptr, __base); return ::wcstoll(__nptr, __endptr, __base);
} }
inline _LIBCPP_HIDE_FROM_ABI int unsigned long long inline _LIBCPP_HIDE_FROM_ABI unsigned long long
wcstoull_l(const wchar_t *__nptr, wchar_t **__endptr, int __base, locale_t) { wcstoull_l(const wchar_t *__nptr, wchar_t **__endptr, int __base, locale_t) {
return ::wcstoull(__nptr, __endptr, __base); return ::wcstoull(__nptr, __endptr, __base);
} }
inline _LIBCPP_HIDE_FROM_ABI int long double inline _LIBCPP_HIDE_FROM_ABI long double
wcstold_l(const wchar_t *__nptr, wchar_t **__endptr, locale_t) { wcstold_l(const wchar_t *__nptr, wchar_t **__endptr, locale_t) {
return ::wcstold(__nptr, __endptr); return ::wcstold(__nptr, __endptr);
} }
#ifdef __cplusplus #ifdef __cplusplus
} }
#endif #endif
#endif // _LIBCPP_SUPPORT_XLOCALE_STRTONUM_FALLBACK_H #endif // _LIBCPP_SUPPORT_XLOCALE_STRTONUM_FALLBACK_H