[PATCH] [clang-tidy] NFC: add preposition "of" to code annotation of ElseAfterReturnCheck

[zhouyizhou]

Summary

Hi,
I think we should add add preposition "of" to code annotation of ElseAfterReturnCheck ;-)
Many Thanks Zhouyi

Zhouyi Zhou <[e-mail]>

[njames93]

While you're here could you also put full stops( or periods 🙃) at the end of the sentences.

[zhouyizhou]

In D129953#3657920, @njames93 wrote:

While you're here could you also put full stops( or periods 🙃) at the end of the sentences.

Thank Nathan for reviewing my patch
I am here, and am very happy to make further enhancement ;-) But because my native language is not English, I don't know where should I put the full stops at .
Isn't "If the if statement is the last statement of its enclosing statements scope, we can pull the decl out of the if statement." constitute a complete sentence?

Thanks again
Zhouyi

[njames93]

In D129953#3657925, @zhouyizhou wrote:

In D129953#3657920, @njames93 wrote:

While you're here could you also put full stops( or periods 🙃) at the end of the sentences.

Thank Nathan for reviewing my patch
I am here, and am very happy to make further enhancement ;-) But because my native language is not English, I don't know where should I put the full stops at .
Isn't "If the if statement is the last statement of its enclosing statements scope, we can pull the decl out of the if statement." constitute a complete sentence?

Thanks again
Zhouyi

They are just used to end sentences, we typically try to put them at the end of every comment in LLVM.

clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp

266

302

[nridge]

clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp

266

This is the middle of a sentence though -- the sentence continues on the next line

[zhouyizhou]

Hi,

I have no write access to LLVM, could you commit for me at your convenience ;-)

Many thanks

Zhouyi Zhou <[e-mail]>

clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp

if (!IsLastInScope && containsDeclInScope(Else)) {
     }
     return;
   }
 
   if (checkConditionVarUsageInElse(If) != nullptr) {
     if (!WarnOnConditionVariables)
       return;
     if (IsLastInScope) {
-      // If the if statement is the last statement its enclosing statements
+      // If the if statement is the last statement of its enclosing statements
       // scope, we can pull the decl out of the if statement.
       DiagnosticBuilder Diag = diag(ElseLoc, WarningMessage)
                                << ControlFlowInterruptor
                                << SourceRange(ElseLoc);
       if (checkInitDeclUsageInElse(If) != nullptr) {
         Diag << tooling::fixit::createReplacement(
                     SourceRange(If->getIfLoc()),
                     (tooling::fixit::getText(*If->getInit(), *Result.Context) +
if (checkConditionVarUsageInElse(If) != nullptr) {
     }
     return;
   }
 
   if (checkInitDeclUsageInElse(If) != nullptr) {
     if (!WarnOnConditionVariables)
       return;
     if (IsLastInScope) {
-      // If the if statement is the last statement its enclosing statements
+      // If the if statement is the last statement of its enclosing statements
       // scope, we can pull the decl out of the if statement.
       DiagnosticBuilder Diag = diag(ElseLoc, WarningMessage)
                                << ControlFlowInterruptor
                                << SourceRange(ElseLoc);
       Diag << tooling::fixit::createReplacement(
                   SourceRange(If->getIfLoc()),
                   (tooling::fixit::getText(*If->getInit(), *Result.Context) +
                    "\n" +