Page MenuHomePhabricator

[clang-format] Fix aligning of trailing comments after comment at the end of a namespace
Needs ReviewPublic

Authored by eoanermine on Jul 15 2022, 12:09 PM.

Details

Summary
  • Fix aligning of trailing comments after comment at the end of a namespace
  • Add tests for aligning of trailing comments after comment that documents the closing of a namespace

Closes https://github.com/llvm/llvm-project/issues/26550

Diff Detail

Event Timeline

eoanermine created this revision.Jul 15 2022, 12:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 15 2022, 12:09 PM
eoanermine requested review of this revision.Jul 15 2022, 12:09 PM
eoanermine retitled this revision from Fix aligning of trailing comments after comment at the end of a namespace to [clang-format] Fix aligning of trailing comments after comment at the end of a namespace.Jul 15 2022, 12:09 PM
eoanermine edited the summary of this revision. (Show Details)Jul 15 2022, 12:17 PM
clang/unittests/Format/FormatTest.cpp
17468–17470

Shouldn't this be aligned?

17479

Why repeat this here with just a longer comment, or do I miss something?