This is an archive of the discontinued LLVM Phabricator instance.

Differential D129815

[MLIR][Presburger] MPInt: add missing fastpath in ceilDiv
ClosedPublic

Authored by arjunp on Jul 14 2022, 4:16 PM.

Details

Reviewers
Groverkss
ftynse
Commits
rG9390b8d34ce3: [MLIR][Presburger] MPInt: add missing fastpath in ceilDiv
Summary

This is not a bug in functionality, just a missed optimization.

Diff Detail

Event Timeline

arjunp created this revision.Jul 14 2022, 4:16 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 14 2022, 4:16 PM
Herald added subscribers: bzcheeseman, sdasgup3, wenzhicui and 19 others. · View Herald Transcript
arjunp requested review of this revision.Jul 14 2022, 4:16 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 14 2022, 4:16 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B175529: Diff 444831.Jul 14 2022, 5:39 PM
Groverkss accepted this revision.Jul 15 2022, 8:43 AM

LGTM

This revision is now accepted and ready to land.Jul 15 2022, 8:43 AM
Closed by commit rG9390b8d34ce3: [MLIR][Presburger] MPInt: add missing fastpath in ceilDiv (authored by arjunp). · Explain WhyJul 15 2022, 9:26 AM
This revision was automatically updated to reflect the committed changes.
arjunp added a commit: rG9390b8d34ce3: [MLIR][Presburger] MPInt: add missing fastpath in ceilDiv.

Revision Contents

PathSize
mlir/
include/
mlir/
Analysis/
Presburger/
1 line

Diff 445020

mlir/include/mlir/Analysis/Presburger/MPInt.h

Show First 20 Lines • Show All 356 Lines • ▼ Show 20 Lines
LLVM_ATTRIBUTE_ALWAYS_INLINE MPInt abs(const MPInt &x) { LLVM_ATTRIBUTE_ALWAYS_INLINE MPInt abs(const MPInt &x) {
return MPInt(x >= 0 ? x : -x); return MPInt(x >= 0 ? x : -x);
} }
// Division overflows only occur when negating the minimal possible value. // Division overflows only occur when negating the minimal possible value.
LLVM_ATTRIBUTE_ALWAYS_INLINE MPInt ceilDiv(const MPInt &lhs, const MPInt &rhs) { LLVM_ATTRIBUTE_ALWAYS_INLINE MPInt ceilDiv(const MPInt &lhs, const MPInt &rhs) {
if (LLVM_LIKELY(lhs.isSmall() && rhs.isSmall())) { if (LLVM_LIKELY(lhs.isSmall() && rhs.isSmall())) {
if (LLVM_UNLIKELY(detail::divWouldOverflow(lhs.getSmall(), rhs.getSmall()))) if (LLVM_UNLIKELY(detail::divWouldOverflow(lhs.getSmall(), rhs.getSmall())))
return -lhs; return -lhs;
return MPInt(mlir::ceilDiv(lhs.getSmall(), rhs.getSmall()));
} }
return MPInt(ceilDiv(detail::SlowMPInt(lhs), detail::SlowMPInt(rhs))); return MPInt(ceilDiv(detail::SlowMPInt(lhs), detail::SlowMPInt(rhs)));
} }
LLVM_ATTRIBUTE_ALWAYS_INLINE MPInt floorDiv(const MPInt &lhs, LLVM_ATTRIBUTE_ALWAYS_INLINE MPInt floorDiv(const MPInt &lhs,
const MPInt &rhs) { const MPInt &rhs) {
if (LLVM_LIKELY(lhs.isSmall() && rhs.isSmall())) { if (LLVM_LIKELY(lhs.isSmall() && rhs.isSmall())) {
if (LLVM_UNLIKELY(detail::divWouldOverflow(lhs.getSmall(), rhs.getSmall()))) if (LLVM_UNLIKELY(detail::divWouldOverflow(lhs.getSmall(), rhs.getSmall())))
return -lhs; return -lhs;
▲ Show 20 Lines • Show All 231 Lines • Show Last 20 Lines