could you please update the status csv file?
puzzle: why does clang-format add two spaces here. I was told don't have spaces here
since the signature of the algorithm have OldType and NewType, it would be good to have at least one test to test when the old_value and new_value have different types
I just looked at it mainly out of curiosity, but I didn't do a in-depth review. But some comments.
|71 ↗||(On Diff #444808)|
Please remove this, it should be in a separate patch. Which I did in D129441 on your request.
This is the inner namespace indention clang-format setting. We're considering to remove that.
It would be nice to commit the upper and lower bound and search separately.
All comments are pretty minor.
Optional: consider a blank line above this line.
Nit: can you add a blank line above this line?
Please also add the definitions of the *_result types to the synopsis.
Should this be replace_copy_result? Also, you might need to update ranges_result_alias_declarations.compile.pass.cpp.
Optional: it would be convenient to copy the exact requirement from the standard here.
Same as the other file, the name needs to be updated.
Same nit re. return type.
I think you also need to check the number of predicate invocations. There's some prior art in test_support/counting_predicates.h.