This is an archive of the discontinued LLVM Phabricator instance.

[BOLT][TEST] Add icp-inline.s test
ClosedPublic

Authored by Amir on Jul 14 2022, 2:01 PM.

Details

Summary

Add a test for -icp-inline knob, which ensures that ICP is only performed for
functions that can be subsequently inlined.

Diff Detail

Event Timeline

Amir created this revision.Jul 14 2022, 2:01 PM
Herald added a reviewer: maksfb. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: ayermolo. · View Herald Transcript
Amir requested review of this revision.Jul 14 2022, 2:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 14 2022, 2:01 PM
rafauler accepted this revision.Jul 15 2022, 3:52 PM
rafauler added inline comments.
bolt/test/X86/icp-inline.s
37

Perhaps add a check that no line containing "callq bar" is found, to check that ICP was not performed?

This revision is now accepted and ready to land.Jul 15 2022, 3:52 PM
rafauler added inline comments.Jul 15 2022, 3:52 PM
bolt/test/X86/icp-inline.s
37

oh but if it is, it would be inlined. nevermind.

Amir updated this revision to Diff 445177.Jul 15 2022, 8:43 PM

Address feedback (CHECK-NOT: call bar)

Amir marked 2 inline comments as done.Jul 15 2022, 8:44 PM
Amir added inline comments.
bolt/test/X86/icp-inline.s
37

Added the check nevertheless.

This revision was automatically updated to reflect the committed changes.