Parse op_sel for *_e64_dpp VOP3 opcodes.
Depends on D129637 and setting of VOP3_OPSEL in dpp pseudos.
Details
Details
Diff Detail
Diff Detail
Event Timeline
Comment Actions
Overall looks good. Some minor comments.
| llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp | ||
|---|---|---|
| 8029 | This is related to the existing behavior of the function, not your change, but this function really needs a documentation comment. Something like "Determines which bit DST_OP_SEL occupies in the op_sel operand according to the number of src operands present, then copies that bit into src0_modifiers" | |
| 8038 | Weird semi-colon, clang-format please | |
| 8042 | Move this check to the beginning of the function for early exit. | |
This is related to the existing behavior of the function, not your change, but this function really needs a documentation comment. Something like "Determines which bit DST_OP_SEL occupies in the op_sel operand according to the number of src operands present, then copies that bit into src0_modifiers"