This is an archive of the discontinued LLVM Phabricator instance.

Fix another typo: compile -> compiled.
ClosedPublic

Authored by sscalpone on Jul 13 2022, 9:24 AM.

Diff Detail

Event Timeline

sscalpone created this revision.Jul 13 2022, 9:24 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 13 2022, 9:24 AM
sscalpone requested review of this revision.Jul 13 2022, 9:24 AM
clementval accepted this revision.Jul 13 2022, 9:26 AM
clementval added a subscriber: clementval.

LGTM. You can push this kind of change without review.

This revision is now accepted and ready to land.Jul 13 2022, 9:26 AM
This revision was landed with ongoing or failed builds.Jul 13 2022, 11:22 AM
This revision was automatically updated to reflect the committed changes.

I'm a little curious to the commit message vs what the diff shows. I'm not saying the change isn't good, but the "fix another typo: compile -> compiled" made me think that it would just be one or a few lines of replacing some "compile" with "compiled", not adding a new .md file... Is this the result of a squash of multiple commits, and the commit message being of the last commit?

I'm not blocking this commit, just saying it would be nice if the message and the patch content matches... :)

I'm a little curious to the commit message vs what the diff shows. I'm not saying the change isn't good, but the "fix another typo: compile -> compiled" made me think that it would just be one or a few lines of replacing some "compile" with "compiled", not adding a new .md file... Is this the result of a squash of multiple commits, and the commit message being of the last commit?

I'm not blocking this commit, just saying it would be nice if the message and the patch content matches... :)

Ah, I see, this patch depends on D129620, but isn't marked as "depends on", so looks like an independent patch adding that file.