This is an archive of the discontinued LLVM Phabricator instance.

Import CI tests from the release branch
ClosedPublic

Authored by tstellar on Jul 11 2022, 5:38 PM.

Details

Summary

The tests still only run on pushes or pull requests for the release
branch, but having it in the main branch means we don't have to copy
the tests every time we create a new release branch.

Diff Detail

Event Timeline

tstellar created this revision.Jul 11 2022, 5:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 11 2022, 5:38 PM
Herald added a subscriber: jvesely. · View Herald Transcript
tstellar requested review of this revision.Jul 11 2022, 5:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 11 2022, 5:38 PM
tstellar updated this revision to Diff 443834.Jul 11 2022, 10:26 PM

Fix included workflow path.

tstellar updated this revision to Diff 444824.Jul 14 2022, 3:50 PM
  • Fix some build failures on macOS and windows.
  • Use newer version of actions/checkout.
asl added a subscriber: asl.Jul 26 2022, 2:54 AM

See comments above

.github/workflows/clang-tests.yml
4

Let's add workflow_dispatch: here as well. So the tests could be triggered manually, if necessary. Same for other pipelines.

29

Is this to skip forks? If yes, then more canonical way is to do:

on:
  push:
    ignore-forks: true
tstellar added inline comments.Jul 26 2022, 9:18 AM
.github/workflows/clang-tests.yml
29

This doesn't seem to work: https://github.com/tstellar/llvm-project/pull/879

I also don't see it documented anywhere, but yet there is no error when I add it.

tstellar updated this revision to Diff 447793.Jul 26 2022, 12:13 PM
  • Add workflow_dispatch so the jobs can be manually run
  • I also added ignore-forks to the workflows. This didn't work in my tests, but I'm not sure why.
tstellar marked an inline comment as done.Jul 26 2022, 12:14 PM
asl accepted this revision.Jul 26 2022, 12:35 PM
asl added inline comments.
.github/workflows/clang-tests.yml
29
This revision is now accepted and ready to land.Jul 26 2022, 12:35 PM
This revision was landed with ongoing or failed builds.Jul 26 2022, 5:06 PM
This revision was automatically updated to reflect the committed changes.