This is an archive of the discontinued LLVM Phabricator instance.

Restore Python install behavior from before D128230.
ClosedPublic

Authored by stellaraccident on Jul 9 2022, 6:37 PM.

Details

Summary

In D128230, we accidentally moved the install for Python sources outside of the loop, having one install() per group of files. While it would be nice if we could do this, it means that we flatten the relative directory tree and every source ends up in the root. The right way to do this is to use FILE_SETS, which preserve the relative directory tree, but they are not available until CMake 3.23.

Diff Detail

Event Timeline

stellaraccident created this revision.Jul 9 2022, 6:37 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 9 2022, 6:37 PM
stellaraccident requested review of this revision.Jul 9 2022, 6:37 PM

FYI - another little glitch. I'm just going to land this for post-review to unblock downstreams (once the CI passes).

This revision was not accepted when it landed; it landed in state Needs Review.Jul 9 2022, 7:23 PM
This revision was automatically updated to reflect the committed changes.