This is an archive of the discontinued LLVM Phabricator instance.

Differential D129321

[BOLT][Runtime] Fix memset definition
ClosedPublic

Authored by yota9 on Jul 7 2022, 12:46 PM.

Details

Reviewers
maksfb
rafauler
Amir
Commits
rGe10e120cea41: [BOLT][Runtime] Fix memset definition

Diff Detail

Event Timeline

yota9 created this revision.Jul 7 2022, 12:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 7 2022, 12:46 PM
Herald added a subscriber: ayermolo. · View Herald Transcript
yota9 requested review of this revision.Jul 7 2022, 12:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 7 2022, 12:46 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B174239: Diff 443032.Jul 7 2022, 12:53 PM
yavtuk added a child revision: D129107: [BOLT][HUGIFY] adds huge pages support of PIE/no-PIE binaries.Jul 8 2022, 3:36 AM
yota9 mentioned this in D128082: [BOLT][AArch64] Handle gold linker veneers.Jul 8 2022, 11:27 AM
maksfb accepted this revision.Jul 8 2022, 1:15 PM

Thanks.

This revision is now accepted and ready to land.Jul 8 2022, 1:15 PM
Closed by commit rGe10e120cea41: [BOLT][Runtime] Fix memset definition (authored by yota9). · Explain WhyJul 8 2022, 3:17 PM
This revision was automatically updated to reflect the committed changes.
yota9 added a commit: rGe10e120cea41: [BOLT][Runtime] Fix memset definition.
yavtuk removed a child revision: D129107: [BOLT][HUGIFY] adds huge pages support of PIE/no-PIE binaries.Oct 13 2022, 1:16 AM

Revision Contents

PathSize
bolt/
runtime/
8 lines

Diff 443369

bolt/runtime/common.h

Show First 20 Lines • Show All 97 Lines • ▼ Show 20 Lines if (d < s) {
d += Len - 1; d += Len - 1;
while (Len--) while (Len--)
*d-- = *s--; *d-- = *s--;
} }
return Dest; return Dest;
} }
void memset(char *Buf, char C, uint32_t Size) { void *memset(void *Buf, int C, size_t Size) {
for (int I = 0; I < Size; ++I) char *S = (char *)Buf;
*Buf++ = C; for (size_t I = 0; I < Size; ++I)
*S++ = C;
return Buf;
} }
int memcmp(const void *s1, const void *s2, size_t n) { int memcmp(const void *s1, const void *s2, size_t n) {
const uint8_t *c1 = static_cast<const uint8_t *>(s1); const uint8_t *c1 = static_cast<const uint8_t *>(s1);
const uint8_t *c2 = static_cast<const uint8_t *>(s2); const uint8_t *c2 = static_cast<const uint8_t *>(s2);
for (; n--; c1++, c2++) { for (; n--; c1++, c2++) {
if (*c1 != *c2) if (*c1 != *c2)
return *c1 < *c2 ? -1 : 1; return *c1 < *c2 ? -1 : 1;
▲ Show 20 Lines • Show All 436 Lines • Show Last 20 Lines