This is an archive of the discontinued LLVM Phabricator instance.

build_symbolizer: Set LLVM_DEFAULT_TARGET_TRIPLE in llvm builds
ClosedPublic

Authored by MatzeB on Jun 28 2022, 7:10 AM.

Details

Summary

Pass on the default target triple of the host clang to the LLVM builds within the build_symbolizer.sh script.

Diff Detail

Event Timeline

MatzeB created this revision.Jun 28 2022, 7:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 28 2022, 7:10 AM
MatzeB requested review of this revision.Jun 28 2022, 7:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 28 2022, 7:10 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript

For background: We had failing builds because the host clang was configured for a default triple of x86_64-redhat-linux-gnu but the symbolizer build using x86_64-unknown-linux-gnu. I suspect this started failing in combination with the new LLVM_ENABLE_PER_TARGET_RUNTIME_DIR default in LLVM expecting libcxx headers and libraries in a subdirectory matching the target triple.

MaskRay accepted this revision.Jun 28 2022, 10:22 AM

@vitalybuka told me that zorg/buildbot/builders/sanitizers/buildbot_cmake.sh uses build_symbolizer.sh.

This revision is now accepted and ready to land.Jun 28 2022, 10:22 AM

BTW: build_symbolizer.sh uses the long obsoleted PROJECTS="-DLLVM_ENABLE_PROJECTS='libcxx;libcxxabi'". We need to migrate to LLVM_ENABLE_RUNTIMES at some point. LLVM_ENABLE_RUNTIMES automatically uses the LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=on file hierarchy.