[LLDB] Fix PDB/pointers.test for 32bit Arm/Windows

[omjavaid]

Summary

PDB/pointers.test was orignally written for 32bit x86 keeping in mind
cdecl and stdcall calling conventions which does name mangling for
example like adding "_" underscore before function name.
This is only x86 specific but purpose of pointers.test is NOT to test
calling convention.
I am have made a few minor changes to this test which will make it pass
when run on Windows/Arm platform.
Ref

[omjavaid]

lldb/test/Shell/SymbolFile/PDB/pointers.test

36

Explaining this change a dwarf location expression tag is added for variables deriving their address location from stack.

[mstorsjo]

I presume this is ok - if the main intent of this test is to test handling of pointers and the size thereof in PDBs.

lldb/test/Shell/SymbolFile/PDB/pointers.test

2

I wonder if it'd be better to hardcode this to build for i386 (assuming the %build script allows that?) to keep it testing what it was originally made to test?

[omjavaid]

lldb/test/Shell/SymbolFile/PDB/pointers.test

2

Given we expect this to pass for Windows/Arm it will reduce coverage if made to run only for x86.

[mstorsjo]

lldb/test/Shell/SymbolFile/PDB/pointers.test

2

Right, as we probably need to link, that would require more of the host environment than we normally require (for other tests where we don't link things, we can compile things for x86 even if we're running on arm, as long as the x86 support is available in the compiler).

Given the structure of the lldb tests I guess this is more in line with how things normally are done here, so I guess this is fine.

lldb/test/Shell/SymbolFile/PDB/pointers.test

 REQUIRES: system-windows, msvc
 RUN: %build --compiler=clang-cl --mode=compile --arch=32 --nodefaultlib --output=%T/PointerTypeTest.cpp.obj %S/Inputs/PointerTypeTest.cpp
 RUN: %build --compiler=msvc --mode=link --arch=32 --nodefaultlib --output=%T/PointerTypeTest.cpp.exe %T/PointerTypeTest.cpp.obj
 RUN: lldb-test symbols %T/PointerTypeTest.cpp.exe | FileCheck %s
 RUN: lldb-test symbols %T/PointerTypeTest.cpp.exe | FileCheck --check-prefix=MAIN-ST-F %s
 RUN: lldb-test symbols %T/PointerTypeTest.cpp.exe | FileCheck --check-prefix=MAIN-ST %s
 RUN: lldb-test symbols %T/PointerTypeTest.cpp.exe | FileCheck --check-prefix=MAIN %s
 RUN: lldb-test symbols %T/PointerTypeTest.cpp.exe | FileCheck --check-prefix=F %s
 
 CHECK: Module [[MOD:.*]]
 CHECK: {{^[0-9A-F]+}}:   CompileUnit{{[{]0x[0-9a-f]+[}]}}, language = "c++", file = '{{.*}}\PointerTypeTest.cpp'
 
 MAIN-ST-F:  name = "f"
 MAIN-ST-F-SAME: decl = PointerTypeTest.cpp:8
 MAIN-ST-F-SAME: compiler_type = {{.*}} int (int)
 
 MAIN-ST:  name = "ST", size = 4, decl = PointerTypeTest.cpp:6, compiler_type = {{.*}} struct ST {
 MAIN-ST-NEXT: int a;
 MAIN-ST-NEXT: int {{.*}}f(int);
 MAIN-ST-NEXT:}
 
-MAIN:   Function{[[FID1:.*]]}, mangled = _main
+MAIN:   Function{[[FID1:.*]]}, mangled = {{_?}}main
 MAIN-NEXT:  Block{[[FID1]]}
 MAIN:     Variable{{.*}}, name = "array_pointer"
 MAIN-SAME:    (int (*)[2][4]), scope = local
 MAIN:     Variable{{.*}}, name = "p_int"
 MAIN-SAME:    (int *), scope = local
 MAIN:     Variable{{.*}}, name = "p_member_field"
 MAIN-SAME:    (int ST::*), scope = local
 MAIN:     Variable{{.*}}, name = "p_member_method"
-MAIN-SAME:    (int (ST::*)(int) __attribute__((thiscall))), scope = local
+MAIN-SAME:    (int (ST::*)(int){{( __attribute__\(\(thiscall\)\))?}}), scope = local
 
 F:   Function{[[FID2:.*]]}, demangled = {{.*}}f(int)
 F-NEXT:  Block{[[FID2]]}
 F:     Variable{{.*}}, name = "this"
-F-SAME:    (ST *), scope = parameter, location = {{.*}}, artificial
+F-SAME:    (ST *), scope = parameter,{{( location = DW_OP.*,)?}} artificial
 F:     Variable{{.*}}, name = "x"
 F-SAME:    (int), scope = parameter, decl = PointerTypeTest.cpp:8