Setting ISD::BR_CC to Expand makes it much easier to deal with
matching the expanded form.
Depends on D128427
Paths
| Differential D128428
[LoongArch] Add codegen support for conditional branches ClosedPublic Authored by wangleiat on Jun 23 2022, 5:10 AM.
Details Summary Setting ISD::BR_CC to Expand makes it much easier to deal with Depends on D128427
Diff Detail
Event Timelinewangleiat added a child revision: D128429: [LoongArch] Add initial support for function calls.Jun 23 2022, 5:12 AM
Comment Actions Someone else more familiar with LLVM internals could teach us about that particular tblgen behavior noted above, but the rest LGTM.
This revision is now accepted and ready to land.Jul 2 2022, 12:53 AM Closed by commit rGb940fe6fe2af: [LoongArch] Add codegen support for conditional branches (authored by wangleiat, committed by SixWeining). · Explain WhyJul 4 2022, 9:01 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 442172 llvm/lib/Target/LoongArch/LoongArchAsmPrinter.h
llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp
llvm/lib/Target/LoongArch/LoongArchInstrInfo.td
llvm/lib/Target/LoongArch/LoongArchMCInstLower.cpp
llvm/test/CodeGen/LoongArch/ir-instruction/br.ll
llvm/test/CodeGen/LoongArch/ir-instruction/indirectbr.ll
|
Could you explain a bit on why this is needed? I can't easily understand this as the only change is on the "guard" of said definition but the dropped check seems too important to ignore. (Maybe because I haven't looked at LLVM source code as hard as you did.)