[BOLT] Restrict icp-inline to callsites

[Amir]

Summary

ICP peel for inline mode only makes sense for calls, not jump tables.
Plus, add a check that the Target BinaryFunction is found.

[rafauler]

LGTM

bolt/lib/Passes/IndirectCallPromotion.cpp

size_t IndirectCallPromotion::canPromoteCallsite(
   size_t TopN = opts::ICPTopN;
   if (IsJumpTable)
     TopN = opts::ICPJumpTablesTopN ? opts::ICPJumpTablesTopN : TopN;
   else
     TopN = opts::ICPCallsTopN ? opts::ICPCallsTopN : TopN;
 
   const size_t TrialN = TopN ? std::min(TopN, Targets.size()) : Targets.size();
 
-  if (opts::ICPTopCallsites > 0) {
-    if (!BC.MIB->hasAnnotation(Inst, "DoICP"))
-      return 0;
-  }
+  if (opts::ICPTopCallsites && !BC.MIB->hasAnnotation(Inst, "DoICP"))
 
   // Pick the top N targets.
   uint64_t TotalMispredictsTopN = 0;
   size_t N = 0;
 
   if (opts::ICPUseMispredicts &&
       (!IsJumpTable || opts::ICPJumpTablesByTarget)) {
     // Count total number of mispredictions for (at most) the top N targets.
if (!IsJumpTable || opts::ICPJumpTablesByTarget) {
         }
         return 0;
       }
     }
   }
 
   // Filter by inline-ability of target functions, stop at first target that
   // can't be inlined.
-  if (opts::ICPPeelForInline) {
+  if (!IsJumpTable && opts::ICPPeelForInline) {
     for (size_t I = 0; I < N; ++I) {
       const MCSymbol *TargetSym = Targets[I].To.Sym;
       const BinaryFunction *TargetBF = BC.getFunctionForSymbol(TargetSym);
-      if (!BinaryFunctionPass::shouldOptimize(*TargetBF) ||
+      if (!TargetBF || !BinaryFunctionPass::shouldOptimize(*TargetBF) ||
           getInliningInfo(*TargetBF).Type == InliningType::INL_NONE) {
         N = I;
         break;
       }
     }
   }
 
   // Filter functions that can have ICP applied (for debugging)