This is an archive of the discontinued LLVM Phabricator instance.

Differential D128237

[mlir][affine] Rigorous check for loop unrolling store operation
ClosedPublic

Authored by Lewuathe on Jun 20 2022, 6:33 PM.

Details

Reviewers
ftynse
Commits
rGbd861056a528: [mlir][affine] Rigorous check for loop unrolling store operation
Summary

Static loop unrolling does not change the operation type. We can rigorously make sure to use affine.store in the check.

Diff Detail

Event Timeline

Lewuathe created this revision.Jun 20 2022, 6:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 20 2022, 6:33 PM
Herald added subscribers: bzcheeseman, sdasgup3, Groverkss and 21 others. · View Herald Transcript
Lewuathe requested review of this revision.Jun 20 2022, 6:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 20 2022, 6:33 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B170951: Diff 438521.Jun 20 2022, 6:34 PM
ftynse accepted this revision.Jun 21 2022, 2:49 AM
This revision is now accepted and ready to land.Jun 21 2022, 2:49 AM
This revision was landed with ongoing or failed builds.Jun 24 2022, 5:32 PM
Closed by commit rGbd861056a528: [mlir][affine] Rigorous check for loop unrolling store operation (authored by Lewuathe). · Explain Why
This revision was automatically updated to reflect the committed changes.
Lewuathe added a commit: rGbd861056a528: [mlir][affine] Rigorous check for loop unrolling store operation.

Revision Contents

PathSize
mlir/
test/
Dialect/
SCF/
2 lines

Diff 438521

mlir/test/Dialect/SCF/loop-unroll.mlir

Show First 20 Lines • Show All 265 Lines • ▼ Show 20 Linesfunc.func @static_loop_unroll_up_to_factor(%arg0 : memref<?xf32>) {
return return
} }
// UNROLL-UP-TO-LABEL: func @static_loop_unroll_up_to_factor // UNROLL-UP-TO-LABEL: func @static_loop_unroll_up_to_factor
// UNROLL-UP-TO-SAME: %[[MEM:.*0]]: memref<?xf32> // UNROLL-UP-TO-SAME: %[[MEM:.*0]]: memref<?xf32>
// //
// UNROLL-UP-TO-DAG: %[[C0:.*]] = arith.constant 0 : index // UNROLL-UP-TO-DAG: %[[C0:.*]] = arith.constant 0 : index
// UNROLL-UP-TO-DAG: %[[C2:.*]] = arith.constant 2 : index // UNROLL-UP-TO-DAG: %[[C2:.*]] = arith.constant 2 : index
// UNROLL-UP-TO-NEXT: %[[V0:.*]] = affine.apply {{.*}} // UNROLL-UP-TO-NEXT: %[[V0:.*]] = affine.apply {{.*}}
// UNROLL-UP-TO-NEXT: store %{{.*}}, %[[MEM]][%[[V0]]] : memref<?xf32> // UNROLL-UP-TO-NEXT: affine.store %{{.*}}, %[[MEM]][%[[V0]]] : memref<?xf32>
// UNROLL-UP-TO-NEXT: %[[V1:.*]] = affine.apply {{.*}} // UNROLL-UP-TO-NEXT: %[[V1:.*]] = affine.apply {{.*}}
// UNROLL-UP-TO-NEXT: affine.store %{{.*}}, %[[MEM]][%[[V1]]] : memref<?xf32> // UNROLL-UP-TO-NEXT: affine.store %{{.*}}, %[[MEM]][%[[V1]]] : memref<?xf32>
// UNROLL-UP-TO-NEXT: return // UNROLL-UP-TO-NEXT: return
// Test that epilogue's arguments are correctly renamed. // Test that epilogue's arguments are correctly renamed.
func.func @static_loop_unroll_by_3_rename_epilogue_arguments() -> (f32, f32) { func.func @static_loop_unroll_by_3_rename_epilogue_arguments() -> (f32, f32) {
%0 = arith.constant 7.0 : f32 %0 = arith.constant 7.0 : f32
%lb = arith.constant 0 : index %lb = arith.constant 0 : index
Show All 34 Lines