This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Remove an outdated comment. NFC.
ClosedPublic

Authored by mstorsjo on Jun 20 2022, 2:23 PM.

Details

Summary

This comment became outdated in 053eb35651906e693906fad6c695fce11415ade7
(but was moved along); that commit moved the code and the comment
to a separate function, with a separate local variable
num_of_bytes_read. On error, the possibly garbage value is never
copied back to the caller's reference, thus the comment is no longer
relevant (and slightly confusing as is).

Diff Detail

Event Timeline

mstorsjo created this revision.Jun 20 2022, 2:23 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 20 2022, 2:23 PM
mstorsjo requested review of this revision.Jun 20 2022, 2:23 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 20 2022, 2:23 PM
This revision is now accepted and ready to land.Jun 21 2022, 12:56 AM
This revision was automatically updated to reflect the committed changes.