This is an archive of the discontinued LLVM Phabricator instance.

[DebugInfo][InstrRef][NFC] Emit variadic debug values from InstrRefLDV
ClosedPublic

Authored by StephenTozer on Jun 20 2022, 7:50 AM.

Details

Summary

In preparation for supporting DBG_VALUE_LIST in InstrRefLDV, this patch adds the logic for emitting DBG_VALUE_LIST instructions from InstrRefLDV. The logical changes here are fairly simple, with the main change being that instead of directly prepending offsets to the DIExpr, we use appendOpsToArg to modify the expression for individual debug operands in the expression. The function emitLoc is also changed to take a list of debug ops, with an empty list meaning an undef value.

Diff Detail

Event Timeline

StephenTozer created this revision.Jun 20 2022, 7:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 20 2022, 7:50 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
StephenTozer requested review of this revision.Jun 20 2022, 7:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 20 2022, 7:50 AM
Orlando accepted this revision.Jul 7 2022, 8:08 AM

LGTM

llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp
916

tiny nit: this seems to have unnecessarily moved

This revision is now accepted and ready to land.Jul 7 2022, 8:08 AM

clang-format, address review comment.

This revision was landed with ongoing or failed builds.Aug 23 2022, 5:23 AM
This revision was automatically updated to reflect the committed changes.