This is an archive of the discontinued LLVM Phabricator instance.

[mlir][Arith] Make --unsigned-when-equivalent use dialect conversion
ClosedPublic

Authored by krzysz00 on Jun 17 2022, 1:41 PM.

Diff Detail

Event Timeline

krzysz00 created this revision.Jun 17 2022, 1:41 PM
krzysz00 requested review of this revision.Jun 17 2022, 1:41 PM
Mogball accepted this revision.Jun 17 2022, 1:55 PM

thanks for refactoring this

mlir/lib/Dialect/Arithmetic/Transforms/UnsignedWhenEquivalent.cpp
25–29
48

I would just inline this

119

You can probably just inline these

141

drop braces

This revision is now accepted and ready to land.Jun 17 2022, 1:55 PM
krzysz00 updated this revision to Diff 438402.Jun 20 2022, 8:02 AM
krzysz00 marked an inline comment as done.

Review comments

This revision was landed with ongoing or failed builds.Jun 20 2022, 8:03 AM
This revision was automatically updated to reflect the committed changes.